Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lld/llm): fix analytics problem #6813

Merged
merged 2 commits into from
May 7, 2024
Merged

fix(lld/llm): fix analytics problem #6813

merged 2 commits into from
May 7, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented May 6, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Analytics

📝 Description

Fix a problem that disabled analytics by default even if the FF analyticsOptIn wasn't used
By default the tracking is enabled for all the users except if :

  • They've disabled it manually in the settings
  • They receive the Feature flag lldAnalyticsOptinPrompt/llmAnalyticsOptinPrompt

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner May 6, 2024 18:19
Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 8:27pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 8:27pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 8:27pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 8:27pm
web-tools ⬜️ Ignored (Inspect) Visit Preview May 6, 2024 8:27pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels May 6, 2024
@LucasWerey LucasWerey changed the title fix(lld): fix analytics problem fix(lld/llm): fix analytics problem May 6, 2024
@LucasWerey LucasWerey merged commit 5051b8e into release May 7, 2024
49 checks passed
@LucasWerey LucasWerey deleted the fix/analytics_ff branch May 7, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants