Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LIVE-9328): swap live app quotes native UI migration #6831

Merged
merged 6 commits into from
May 15, 2024

Conversation

cng-ledger
Copy link
Contributor

@cng-ledger cng-ledger commented May 10, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Migrating more native UI to swap live app. Moved loading state and swap form summary (target account & network fee) to Swap migration UI native component, to conditionally show the UI.j

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cng-ledger cng-ledger requested a review from a team as a code owner May 10, 2024 08:44
Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 3:57pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 3:57pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 3:57pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 3:57pm
web-tools ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 3:57pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label May 10, 2024
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸš€

@cng-ledger cng-ledger merged commit 5fe062e into develop May 15, 2024
32 of 33 checks passed
@cng-ledger cng-ledger deleted the LIVE-9328 branch May 15, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant