fix(llm): improve readability of supply info in the market #6842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
mcayuelas-ledger
requested changes
May 13, 2024
| return `${formattedValue} ${upperCaseTicker}`.trim(); | ||
| } | ||
|
|
||
| return value + ""; |
There was a problem hiding this comment.
value + ""; We can't justy do return value ; ?
There was a problem hiding this comment.
counterValueFormatter is typed to return a string only I can update it to return a string or a number but I am not sure if it's what we want
There was a problem hiding this comment.
It might be better to keep only one type since it will mainly returns a string instead of just a number Lmk
apps/ledger-live-mobile/src/newArch/features/Market/utils/index.ts
Outdated
Show resolved
Hide resolved
mcayuelas-ledger
previously approved these changes
May 13, 2024
mcayuelas-ledger
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Improvement of the readability of the data in the supply info section for the coin. Add "." or "," or " " every 3 digits and ticker name at the end.
❓ Context
🧐 Checklist for the PR Reviewers