Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix manifest loading breaking if no cache #6843

Merged
merged 6 commits into from
May 13, 2024

Conversation

Wozacosta
Copy link
Contributor

@Wozacosta Wozacosta commented May 13, 2024

  • to replicate the error you'd need to empty out your cache on LLD before replicating the bug
SCR-20240513-mirw

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Wozacosta Wozacosta requested a review from a team as a code owner May 13, 2024 11:45
Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 13, 2024 2:54pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 2:54pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 2:54pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 2:54pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 2:54pm

@live-github-bot live-github-bot bot added the common Has changes in live-common label May 13, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on PlatformAppProviderWrapper.tsx in ledger-live-mobile and ledger-live-desktop :

Change :

    state => state.localLiveApp || INITIAL_PLATFORM_STATE.localLiveApp,

To :

    state => state.localLiveApp,

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels May 13, 2024
@Wozacosta Wozacosta changed the title call filter conditionally fix manifest loading breaking if no cache May 13, 2024
@Wozacosta Wozacosta merged commit 6885312 into develop May 13, 2024
57 of 58 checks passed
@Wozacosta Wozacosta deleted the bugfix/LIVE-12542-fix-manifest-loading branch May 13, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants