(chore): [LL] CVS v3 migration on Market #6850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
live-github-bot
bot
added
desktop
mcayuelas-ledger
force-pushed
the
support/cvs-migration-market
branch
2 times, most recently
from
035d640
to
b32337e
Compare
mcayuelas-ledger
force-pushed
the
support/cvs-migration-market
branch
from
a689889
to
e675618
Compare
KVNLS
approved these changes
May 27, 2024
Comment on lines
36
to
46
| switch (range) { | ||
| case "all": | ||
| case "year": | ||
| return selectedCoinData.priceChangePercentage["1y"]; | ||
| case "month": | ||
| return selectedCoinData.priceChangePercentage["30d"]; | ||
| case "week": | ||
| return selectedCoinData.priceChangePercentage["7d"]; | ||
| default: | ||
| case "day": | ||
| return selectedCoinData.priceChangePercentage["24h"]; |
There was a problem hiding this comment.
Could you use values from KeysPriceChange instead of hardcoded values, please?
Maybe we could have a mapping here instead of a switch
| props.order, | ||
| { | ||
| counterCurrency: props.counterCurrency, | ||
| ...(props.search && props.search?.length > 1 && { search: props.search }), |
mcayuelas-ledger
force-pushed
the
support/cvs-migration-market
branch
from
e675618
to
0546350
Compare
mcayuelas-ledger
force-pushed
the
support/cvs-migration-market
branch
from
44d6dd3
to
e1e838e
Compare
cgrellard-ledger
approved these changes
May 28, 2024
mcayuelas-ledger
merged commit 76004fe
into
support/react-query-market-llm-bis
57 of 67 checks passed
mcayuelas-ledger
added a commit
that referenced
this pull request
May 31, 2024
…6428) * WIP * WIP 2 * Add tool in settings * Remove MarketDataProvider from LLD * WIP 3 * Clean code 🧹 * fix some lint checks * Fix Search and LiveCompatible filter * 🧹 * fix some bugs * isLiveSupported wasn't used in codebase in both LLM/LLD * Reorg files * Reorg files * Fix BreadCrump * fix loader * Enrich market store * fix type in store * Reorg hook's content * Fix search and stared api call + Countervalue/range in MarketCoin + fix e2E tests * Add FF refreshTime rate for LLD * test(lld): update screenshots (ubuntu-latest) lld, test, screenshot * test(lld): update screenshots (ubuntu-latest) lld, test, screenshot * Fix some reviews comments * Mask graphs * remove darwin * test(lld): update screenshots (ubuntu-latest) lld, test, screenshot * Add Mask EthStacking * fix marketCoin screenshot * test(lld): update screenshots (ubuntu-latest) lld, test, screenshot * Add peerDependency * Add changeset * Only 1 call for range * Mask items + fix screenshots * test(lld): update screenshots (ubuntu-latest) lld, test, screenshot * Mask itemson ethStacking test * test(lld): update screenshots (ubuntu-latest) lld, test, screenshot * Mask items on Coin detail page * Refresh on Scroll or on position page every x time * Add some test on utils * test(lld): update screenshots (ubuntu-latest) lld, test, screenshot * Fix coming back to page and don't refetch everything * test(lld): update screenshots (ubuntu-latest) lld, test, screenshot * test(lld): update screenshots (ubuntu-latest) lld, test, screenshot * Fix refetch * Fix double fetch * Fix color in chart * test(lld): update screenshots (ubuntu-latest) lld, test, screenshot * WIP * Rework Store for Market * WIP * Add FF refresh in LLM * Fix Market + improve fetch * WIP ON detail Coin * Add useMArket hook * WIP * WIP * Update hooks * Remove unused dependency * Add refresh on scroll and evry X time * revert changes on this file * Reorg files * Fix typecheck * Remove unused stuff * Fix typecheck * Fix Starred coins * Fix double loading component + Starred Empty State * WIP FIX e2e * fix props * Fix E2e * fix e2e * Fix types * Fix some UI details in MarketDetail page when loading * fix Merge * Fix CounterValu in Stats * (chore): [LL] CVS v3 migration on Market (#6850) * WIP for LLD * WIP LLM * WIP LLM 2 * Fix color in graph llm * fix lint + remove unesed stuff + handle starred/liveCoin * add ids fields * Add order in LLD * Order in LLM + fix some UI bugs * Order in LLD * Add icons * remove log * Improve stuffs * Chnagesets * Fix unimported * Fix Tests LLD * test(lld): update screenshots (ubuntu-latest) lld, test, screenshot * fix Market integration test * Fix page fetched * Fix reviews * Fix lint --------- Co-authored-by: live-github-bot[bot] <105061298+live-github-bot[bot]@users.noreply.github.com> * Fix price null issue + clean some code * FIX LIVE-11870 * Fix lint * test(lld): update screenshots (ubuntu-latest) lld, test, screenshot --------- Co-authored-by: live-github-bot[bot] <105061298+live-github-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
The main objective of this PR is to use CVS v3 on the MArket part in all LL.
Redesign of certain functions in live-common
Use in LLM
Use in LLD
Improvements to the UI
More details in Jira ticket
❓ Context
🧐 Checklist for the PR Reviewers