[LIVE-12852] Bugfix - Extend expired time for TRC20 #6852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
lambertkevin
previously approved these changes
May 14, 2024
gre
requested changes
May 23, 2024
gre
previously approved these changes
May 31, 2024
lambertkevin
previously approved these changes
May 31, 2024
lambertkevin
dismissed
their stale review
CI is completely red so removing my review for now
lambertkevin
force-pushed
the
feat/increate-trc20-expired-time
branch
from
3ebfafc
to
b8281fe
Compare
lambertkevin
changed the title
lambertkevin
force-pushed
the
feat/increate-trc20-expired-time
branch
from
b8281fe
to
acd397b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Following Tron PR https://github.com/LedgerHQ/ledger-live/pull/3783/files, Vault support TRC20 as well now. But simillar to before, Tr20 transaction had to be signed in 30 seconds. Ledger Vault takes more time to approve, especially if the transaction requires multiple approvals.
Also adds the
SKIP_ONBOARDINGenv variable to thehasCompletedOnboardingSelectorof LLD to skip the onboarding for Vault users.❓ Context
Vault client are unable to perform TRC20 tx because they can not approve a tx in 30 seconds
🧐 Checklist for the PR Reviewers