Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(llm): improve layout on Designed for Stax NFT drawer #6855

Merged
merged 1 commit into from
May 14, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented May 14, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Designed for Stax NFTs drawer

📝 Description

There was a linebreak between “E” and “Ink” in the text displayed for “Designed for Stax” NFTs
Add unicode in translation files so "E Ink Screen" will always remain in the same line. This handles even changes directly done in phone settings on font size.

Before After
image image

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) May 14, 2024 1:49pm
ledger-live-github-bot ⬜️ Ignored (Inspect) May 14, 2024 1:49pm
native-ui-storybook ⬜️ Ignored (Inspect) May 14, 2024 1:49pm
react-ui-storybook ⬜️ Ignored (Inspect) May 14, 2024 1:49pm
web-tools ⬜️ Ignored (Inspect) May 14, 2024 1:49pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels May 14, 2024
@LucasWerey LucasWerey requested a review from a team May 14, 2024 14:40
Copy link
Member

@KVNLS KVNLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@LucasWerey LucasWerey merged commit 77012ea into develop May 14, 2024
37 of 44 checks passed
@LucasWerey LucasWerey deleted the fix/LIVE-12422 branch May 14, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants