Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVE-2899 FTX swap on mobile #687

Merged
merged 67 commits into from
Oct 5, 2022
Merged

LIVE-2899 FTX swap on mobile #687

merged 67 commits into from
Oct 5, 2022

Conversation

JunichiSugiura
Copy link
Contributor

@JunichiSugiura JunichiSugiura commented Jul 19, 2022

📝 Description

Add FTX EU / US as a swap provider.

Known issues

  • React Navigation type error (Not a blocker for this PR)
  • login widget still shows ftx mobile app modal 🤔
  • The FTX page to do KYC is formatted badly, and in general is extremely painful to use (we need to work with FTX on this)

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): LIVE-2899

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

Screen.Recording.2022-08-24.at.17.39.02.mov

🚀 Expectations to reach

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2022

🦋 Changeset detected

Latest commit: bd9513b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ledgerhq/live-common Patch
live-mobile Patch
@ledgerhq/live-cli Patch
live-common-tools Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
live-common-tools ✅ Ready (Inspect) Visit Preview Oct 4, 2022 at 4:31PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 4, 2022 at 4:31PM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Oct 4, 2022 at 4:31PM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Oct 4, 2022 at 4:31PM (UTC)

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Base: 48.14% // Head: 48.11% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (bd9513b) compared to base (8610f3a).
Patch coverage: 51.61% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           hotfix     #687      +/-   ##
==========================================
- Coverage   48.14%   48.11%   -0.04%     
==========================================
  Files         688      688              
  Lines       30322    30330       +8     
  Branches     7908     7911       +3     
==========================================
- Hits        14599    14592       -7     
- Misses      14504    14573      +69     
+ Partials     1219     1165      -54     
Flag Coverage Δ
test 48.11% <51.61%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mmon/src/exchange/swap/hooks/useReverseAccounts.ts 100.00% <ø> (ø)
...mmon/src/exchange/swap/hooks/useUpdateMaxAmount.ts 100.00% <ø> (ø)
...edger-live-common/src/exchange/swap/utils/index.ts 63.52% <0.00%> (-1.54%) ⬇️
...ive-common/src/exchange/swap/hooks/useFromState.ts 96.29% <50.00%> (ø)
...common/src/exchange/swap/hooks/useProviderRates.ts 94.93% <50.00%> (ø)
...mmon/src/exchange/swap/hooks/useSwapTransaction.ts 47.36% <50.00%> (-2.64%) ⬇️
...n/src/exchange/swap/hooks/usePickDefaultAccount.ts 100.00% <100.00%> (ø)
...common/src/exchange/swap/hooks/usePollKYCStatus.ts 100.00% <100.00%> (ø)
...-live-common/src/exchange/swap/hooks/useToState.ts 100.00% <100.00%> (ø)
libs/ledger-live-common/src/network.ts 70.93% <0.00%> (-6.98%) ⬇️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Jul 25, 2022

@JunichiSugiura

Screenshots: ✅

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@ggilchrist-ledger
Copy link
Contributor

ggilchrist-ledger commented Jul 25, 2022

Some fixes:

  • ‘Go back to swap’ button a bit confusing after account add. Can we change it to 'Add account' 'Continue' like the rest of the app?
  • Crash on clicking ‘target account’
  • List of 'to' currencies shows random ERC20 tokesn first. It should be in market cap order
  • No error message is shown when the amount entered is too low for any provider
  • This typo after a swap is made:

image

  • Ftx in lower case:

image

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

@JunichiSugiura

Screenshots: ❌

It seems this PR contains screenshots that are different from the base branch.
If you are sure all those changes are correct, you can comment on this PR with /generate-screenshots to update those screenshots.

Make sure all the changes are correct before running the command, as it will commit and push the new result to the PR.

linux

Actual Diff Expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected
v3-onboarding-complete-actual v3-onboarding-complete-diff v3-onboarding-complete-expected

windows

Actual Diff Expected
discover-actual discover-diff discover-expected
discover-actual discover-diff discover-expected

@github-actions github-actions bot removed automation CI/CD stuff ledgerjs Has changes in the ledgerjs open source libs screenshots Screenshots have been updated labels Oct 4, 2022
@JunichiSugiura
Copy link
Contributor Author

/generate-screenshots

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

…m only on mobile)

bump flipper

fix nav error

seperate changeset

cleanup

cleanup

fix widget error on kyc screen
@github-actions github-actions bot added the screenshots Screenshots have been updated label Oct 4, 2022
Copy link
Contributor

@Justkant Justkant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JunichiSugiura JunichiSugiura merged commit c7e40bf into hotfix Oct 5, 2022
@JunichiSugiura JunichiSugiura deleted the feat/ftx-mobile-2 branch October 5, 2022 07:49
ghost pushed a commit that referenced this pull request Oct 7, 2022
* PE-1292: Update self-hosted AWS EC2 runners creation and destroying (#1432)

* Cherry-pick 4798caa (#1436)

PE-1292: Update self-hosted AWS EC2 runners creation and destroying (#1430)

Co-authored-by: Roman Laschuk <[email protected]>

* 🚀 entering LLM hotfix mode

* LIVE-2899 FTX swap on mobile (#687)

adopt desktop to new swap types

new mobile swap with ftx support

* add excludeFixedRates option to useSwapTransaction hook (and hide them only on mobile)

Co-authored-by: Team Live <[email protected]>
Co-authored-by: Kant <[email protected]>

* provide a fix for CI

* 🔥 hotfix prerelease [LLM(3.9.1-hotfix.0)]

* Smartling on-demand translation delivery from hotfix (#1481)

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to zh-CN locale

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to fr-FR locale

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to de-DE locale

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to ja-JP locale

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to pt-BR locale

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to ru-RU locale

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to es-ES locale

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to tr-TR locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to ar-AE locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to zh-CN locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to fr-FR locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to de-DE locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to ja-JP locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to ko-KR locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to pt-BR locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to ru-RU locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to es-ES locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to tr-TR locale

* 🔥 hotfix release [skip ci]

Co-authored-by: Roman Laschuk <[email protected]>
Co-authored-by: Team Live <[email protected]>
Co-authored-by: Junichi Sugiura <[email protected]>
Co-authored-by: Kant <[email protected]>
Co-authored-by: Valentin D. Pinkman <[email protected]>
Co-authored-by: Ledger Live <[email protected]>
ghost pushed a commit that referenced this pull request Oct 12, 2022
* PE-1292: Update self-hosted AWS EC2 runners creation and destroying (#1432)

* Cherry-pick 4798caa (#1436)

PE-1292: Update self-hosted AWS EC2 runners creation and destroying (#1430)

Co-authored-by: Roman Laschuk <[email protected]>

* 🚀 entering LLM hotfix mode

* LIVE-2899 FTX swap on mobile (#687)

adopt desktop to new swap types

new mobile swap with ftx support

* add excludeFixedRates option to useSwapTransaction hook (and hide them only on mobile)

Co-authored-by: Team Live <[email protected]>
Co-authored-by: Kant <[email protected]>

* LIVE-3253 - LLM - add referral program discover card

* provide a fix for CI

* 🔥 hotfix prerelease [LLM(3.9.1-hotfix.0)]

* Smartling on-demand translation delivery from hotfix (#1481)

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to zh-CN locale

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to fr-FR locale

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to de-DE locale

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to ja-JP locale

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to pt-BR locale

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to ru-RU locale

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to es-ES locale

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to tr-TR locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to ar-AE locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to zh-CN locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to fr-FR locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to de-DE locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to ja-JP locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to ko-KR locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to pt-BR locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to ru-RU locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to es-ES locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to tr-TR locale

* 🔥 hotfix release [skip ci]

* Merge pull request #1503 from LedgerHQ/support/pe-1292-fix-instance-volume-size

PE-1292: Fix instance volume size for EC2 Runners

* 🚀 entering LLM hotfix mode

* 🔥 hotfix prerelease [LLM(3.9.1)]

* 🔥 hotfix prerelease [LLM(3.9.2-hotfix.0)]

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to ar-AE locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to zh-CN locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to fr-FR locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to de-DE locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to ja-JP locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to ko-KR locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to pt-BR locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to ru-RU locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to es-ES locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to tr-TR locale

* 🔥 hotfix release [skip ci]

* Update @ledgerhq/types-live README

Co-authored-by: Roman Laschuk <[email protected]>
Co-authored-by: Team Live <[email protected]>
Co-authored-by: Junichi Sugiura <[email protected]>
Co-authored-by: Kant <[email protected]>
Co-authored-by: LFBarreto <[email protected]>
Co-authored-by: Valentin D. Pinkman <[email protected]>
Co-authored-by: Ledger Live <[email protected]>
Co-authored-by: Valentin D. Pinkman <[email protected]>
Co-authored-by: desirendr <[email protected]>
ghost pushed a commit that referenced this pull request Oct 27, 2022
* PE-1292: Update self-hosted AWS EC2 runners creation and destroying (#1432)

* Cherry-pick 4798caa (#1436)

PE-1292: Update self-hosted AWS EC2 runners creation and destroying (#1430)

Co-authored-by: Roman Laschuk <[email protected]>

* 🚀 entering LLM hotfix mode

* LIVE-2899 FTX swap on mobile (#687)

adopt desktop to new swap types

new mobile swap with ftx support

* add excludeFixedRates option to useSwapTransaction hook (and hide them only on mobile)

Co-authored-by: Team Live <[email protected]>
Co-authored-by: Kant <[email protected]>

* LIVE-3253 - LLM - add referral program discover card

* provide a fix for CI

* 🔥 hotfix prerelease [LLM(3.9.1-hotfix.0)]

* Smartling on-demand translation delivery from hotfix (#1481)

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to zh-CN locale

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to fr-FR locale

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to de-DE locale

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to ja-JP locale

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to pt-BR locale

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to ru-RU locale

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to es-ES locale

* File apps/ledger-live-desktop/static/i18n/en/app.json was translated to tr-TR locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to ar-AE locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to zh-CN locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to fr-FR locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to de-DE locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to ja-JP locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to ko-KR locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to pt-BR locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to ru-RU locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to es-ES locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to tr-TR locale

* 🔥 hotfix release [skip ci]

* Merge pull request #1503 from LedgerHQ/support/pe-1292-fix-instance-volume-size

PE-1292: Fix instance volume size for EC2 Runners

* 🚀 entering LLM hotfix mode

* 🔥 hotfix prerelease [LLM(3.9.1)]

* 🔥 hotfix prerelease [LLM(3.9.2-hotfix.0)]

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to ar-AE locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to zh-CN locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to fr-FR locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to de-DE locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to ja-JP locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to ko-KR locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to pt-BR locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to ru-RU locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to es-ES locale

* File apps/ledger-live-mobile/src/locales/en/common.json was translated to tr-TR locale

* 🔥 hotfix release [skip ci]

* Merge branch 'release'

* fix: remove changesets from main

* Re-generate pnpm-lock.yaml for main (#1602)

* Update pnpm-lock.yaml

* chore(🍏): regenerate podfile

* trigger CI

Co-authored-by: Team Live <[email protected]>
Co-authored-by: hzheng-ledger <[email protected]>

* chore: remove npm bump

* 🚀 entering LLD hotfix mode

* [LIVE-4283] Hotfix - Update getFeesEstimation for EVM to prevent usage of getFeeData (#1620)

* Update getFeesEstimation for EVM to prevent usage of `getFeeData` method which is hardcoding priority fees

* changeset

* Add retries on timeout for etherscan api

* pnpm lock update to fix CI

* 🔥 hotfix prerelease [LLD(2.49.1-hotfix.0)]

* 🔥 hotfix release [skip ci]

* Update pnpm-lock.yaml

* regen README

* Solve missing conflict

* Fix duplicate after conflict

* Revert wrong playwright snapshots

Co-authored-by: Roman Laschuk <[email protected]>
Co-authored-by: Team Live <[email protected]>
Co-authored-by: Junichi Sugiura <[email protected]>
Co-authored-by: Kant <[email protected]>
Co-authored-by: LFBarreto <[email protected]>
Co-authored-by: Valentin D. Pinkman <[email protected]>
Co-authored-by: Ledger Live <[email protected]>
Co-authored-by: Valentin D. Pinkman <[email protected]>
Co-authored-by: desirendr <[email protected]>
Co-authored-by: Alexandre Magaud <[email protected]>
Co-authored-by: hzheng-ledger <[email protected]>
Co-authored-by: elbywan <[email protected]>
Co-authored-by: Kévin Lambert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM screenshots Screenshots have been updated tools Has changes in tools translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants