Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix elrond coin config name #6887

Merged
merged 3 commits into from
May 21, 2024
Merged

fix elrond coin config name #6887

merged 3 commits into from
May 21, 2024

Conversation

lvndry
Copy link
Contributor

@lvndry lvndry commented May 20, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

The coin configuration for a currency should be named config_currency_<currencyName> however the name was not correct for elrond

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@lvndry lvndry self-assigned this May 20, 2024
@vercel Vercel
Copy link

vercel bot commented May 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 20, 2024 2:33pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 20, 2024 2:33pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 20, 2024 2:33pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 20, 2024 2:33pm
web-tools ⬜️ Ignored (Inspect) Visit Preview May 20, 2024 2:33pm

@live-github-bot live-github-bot bot added the common Has changes in live-common label May 20, 2024
@live-github-bot live-github-bot bot added the mobile Has changes in LLM label May 20, 2024
@lvndry lvndry changed the title fix elrond default coin config fix elrond coin config name May 20, 2024
@lvndry lvndry marked this pull request as ready for review May 20, 2024 14:48
@lvndry lvndry requested review from a team as code owners May 20, 2024 14:48
sprohaszka-ledger
sprohaszka-ledger approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@sprohaszka-ledger sprohaszka-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it is "normal" that getCurrencyConfiguration throw an error. That means that every currency must have a configuration.
Maybe we should change this default behaviour.

@lvndry lvndry merged commit 7bbad43 into develop May 21, 2024
58 of 64 checks passed
@lvndry lvndry deleted the bugfix/elrond-coin-config branch May 21, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sprohaszka-ledger sprohaszka-ledger sprohaszka-ledger approved these changes

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger approved these changes

Assignees

@lvndry lvndry

Labels
common Has changes in live-common mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lvndry @sprohaszka-ledger @mcayuelas-ledger