Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wallet sync integration test #6899

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented May 21, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Restore Wallet Sync integration test by fixing our Design System theme usage + by forcing styled-component dependency in Jest.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@KVNLS KVNLS self-assigned this May 21, 2024
@KVNLS KVNLS requested a review from a team as a code owner May 21, 2024 13:58
Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 1:59pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 1:59pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 1:59pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 1:59pm
web-tools ⬜️ Ignored (Inspect) May 21, 2024 1:59pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD ui Has changes in the design system library labels May 21, 2024
@KVNLS KVNLS merged commit 57d24ee into develop May 21, 2024
40 of 41 checks passed
@KVNLS KVNLS deleted the fix/wallet-sync-integration-test branch May 21, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants