Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to Electron 30 #6907

Merged
merged 2 commits into from
May 30, 2024
Merged

chore: update to Electron 30 #6907

merged 2 commits into from
May 30, 2024

Conversation

gre
Copy link
Contributor

@gre gre commented May 23, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • LLD app

📝 Description

Electron 29.0.0 | Electron

Electron 30.0.0 | Electron

Update to Electron 30 (and strictly Electron dependencies. there are opportunity to update other electron libs in future, but it will requires us to also enable ESM, which is not yet mandatory)

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 1:46pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 1:46pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 1:46pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 1:46pm
web-tools ⬜️ Ignored (Inspect) Visit Preview May 27, 2024 1:46pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label May 23, 2024
Copy link

socket-security bot commented May 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] Transitive: environment, filesystem, network, shell +35 1.22 MB

🚮 Removed packages: npm/[email protected]

View full report↗︎

valpinkman
valpinkman previously approved these changes May 23, 2024
@gre gre merged commit b19d31d into develop May 30, 2024
56 checks passed
@gre gre deleted the live-11828 branch May 30, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants