[LIVE-12648] Crash because of invalid DeviceModelId

[ofreyssinet-ledger]

✅ Checklist

• npx changeset was attached.
• Covered by automatic tests.
• Impact of the changes:
  • USB connection on Android

📝 Description

The store has some bad data in it because we are doing bad type assertions of some objects into the Device type.
It's currently causing crashes at different levels of LLM, on Android.

The solution proposed here is:

• Remove the as Device type assertions. If an object is incorrect (here, because it does not contain device model id), it is actually unusable so it should be ignored. We could not reproduce the issue but it appears that in some rare cases, the "device discovery" of the Android USB transport sends event with such invalid objects.
• Fix the selectors so that they filter out this invalid data. In cases where it previously would have crashed, it will just behave as if the last connected device was not saved, so the app stays fonctional. The invalid data will be replaced at some point in the store, the next time the user connects a device.

❓ Context

• JIRA or GitHub link: LIVE-12648, Sentry issue #1, Sentry issue #2

---

🧐 Checklist for the PR Reviewers

• The code aligns with the requirements described in the linked JIRA or GitHub issue.
• The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
• There are no undocumented trade-offs, technical debt, or maintainability issues.
• The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
• Any new dependencies have been justified and documented.
• Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
ledger-live-docs	⬜️ Ignored (Inspect)	Visit Preview		May 24, 2024 5:30pm
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview		May 24, 2024 5:30pm
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview		May 24, 2024 5:30pm
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview		May 24, 2024 5:30pm
web-tools	⬜️ Ignored (Inspect)	Visit Preview		May 24, 2024 5:30pm

[valpinkman]

😍

[valpinkman]

Very good. From what we saw together it definitely make things more robust.
And shipped with tests 👌