Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass correct target and source currency ids to swap live app #6914

Merged

Conversation

kallen-ledger
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

  • pass correct target and source currency ids to swap live app

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@kallen-ledger kallen-ledger requested a review from a team as a code owner May 23, 2024 10:31
Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) May 23, 2024 10:31am
ledger-live-github-bot ⬜️ Ignored (Inspect) May 23, 2024 10:31am
native-ui-storybook ⬜️ Ignored (Inspect) May 23, 2024 10:31am
react-ui-storybook ⬜️ Ignored (Inspect) May 23, 2024 10:31am
web-tools ⬜️ Ignored (Inspect) May 23, 2024 10:31am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label May 23, 2024
@kallen-ledger kallen-ledger merged commit 65821db into develop May 23, 2024
35 checks passed
@kallen-ledger kallen-ledger deleted the fix/pass-correct-target-and-soruce-currency-ids branch May 23, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants