Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hides title for Buy screen #6922

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

chrisduma-ledger
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Buy screen title should not be shown anymore

πŸ“ Description

Does not show the default title that comes with React Navigation when navigating to the Buy screen.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) May 23, 2024 7:41pm
ledger-live-github-bot ⬜️ Ignored (Inspect) May 23, 2024 7:41pm
native-ui-storybook ⬜️ Ignored (Inspect) May 23, 2024 7:41pm
react-ui-storybook ⬜️ Ignored (Inspect) May 23, 2024 7:41pm
web-tools ⬜️ Ignored (Inspect) May 23, 2024 7:41pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label May 23, 2024
@chrisduma-ledger chrisduma-ledger merged commit 5ffc989 into develop May 23, 2024
38 checks passed
@chrisduma-ledger chrisduma-ledger deleted the fix/LIVE-12357-hide-title branch May 23, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants