Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📈 : [SUPPORT] Update Market Widget Button clicks analytics #6925

Merged
merged 1 commit into from
May 24, 2024
Merged

📈 : [SUPPORT] Update Market Widget Button clicks analytics #6925

merged 1 commit into from
May 24, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented May 24, 2024 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Update Market Widget Button clicks analytics

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner May 24, 2024 08:18
@vercel Vercel
Copy link

vercel bot commented May 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 24, 2024 2:56pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 24, 2024 2:56pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 24, 2024 2:56pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 24, 2024 2:56pm
web-tools ⬜️ Ignored (Inspect) Visit Preview May 24, 2024 2:56pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label May 24, 2024
@mcayuelas-ledger mcayuelas-ledger force-pushed the support/update-analytics-widget branch from 0181bf6 to a2c5282 Compare May 24, 2024 14:55
@mcayuelas-ledger mcayuelas-ledger merged commit 69a7d59 into develop May 24, 2024
33 of 34 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the support/update-analytics-widget branch May 24, 2024 15:09
lvndry pushed a commit that referenced this pull request May 27, 2024
@mcayuelas-ledger @lvndry
📈 : [SUPPORT] Update Market Widget Button clicks analytics (#6925)
ca0ea6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrellard-ledger cgrellard-ledger cgrellard-ledger approved these changes

@KVNLS KVNLS KVNLS approved these changes

Assignees

@mcayuelas-ledger mcayuelas-ledger

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcayuelas-ledger @cgrellard-ledger @KVNLS