Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 : [BUGFIX] Fix trad of Update firmware banner when updating selected language #6933

Merged
merged 2 commits into from
May 24, 2024
Merged

🐛 : [BUGFIX] Fix trad of Update firmware banner when updating selected language #6933

merged 2 commits into from
May 24, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

There was an issue when updating selected language for LLD and when you had banner displayed. Translation wasn't updated correclty, you had to change page or do an action to update translation

BEFORE

Screen.Recording.2024-05-24.at.15.39.27.mov

AFTER

Screen.Recording.2024-05-24.at.15.38.05.mov

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner May 24, 2024 13:43
@vercel Vercel
Copy link

vercel bot commented May 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview May 24, 2024 2:06pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview May 24, 2024 2:06pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 24, 2024 2:06pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview May 24, 2024 2:06pm
web-tools ⬜️ Ignored (Inspect) Visit Preview May 24, 2024 2:06pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label May 24, 2024
@mcayuelas-ledger mcayuelas-ledger merged commit 636dd1e into develop May 24, 2024
33 of 34 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the bugfix/update-banner-trad branch May 24, 2024 14:54
lvndry pushed a commit that referenced this pull request May 27, 2024
@mcayuelas-ledger @lvndry
🐛 : [BUGFIX] Fix trad of Update firmware banner when updating selecte…
d0848d0 
…d language (#6933)

* 🐛 : [BUGFIX] Fix trad of Update firmware banner when updating selected language

* use <Text/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrellard-ledger cgrellard-ledger cgrellard-ledger approved these changes

Assignees

@mcayuelas-ledger mcayuelas-ledger

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcayuelas-ledger @cgrellard-ledger