Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not remove useAllAmount for polkadot swaps #6997

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

CremaFR
Copy link
Member

@CremaFR CremaFR commented Jun 3, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

- JIRA or GitHub link:


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@CremaFR CremaFR requested a review from a team as a code owner June 3, 2024 13:03
Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Jun 3, 2024 1:03pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Jun 3, 2024 1:03pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 1:03pm
react-ui-storybook ⬜️ Ignored (Inspect) Jun 3, 2024 1:03pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 3, 2024 1:03pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Jun 3, 2024
@CremaFR CremaFR merged commit 9ebead5 into develop Jun 4, 2024
49 of 51 checks passed
@CremaFR CremaFR deleted the bugfix/LIVE-11283 branch June 4, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants