Synchronous onboarding and PostOnboarding on Desktop #700

thomasrogerlux · 2022-07-20T15:29:00Z

📝 Description

This pull request serves as a base branch for the ongoing effort to bring synchronous onboarding and the post onboarding hub to Ledger Live Desktop.

Screenshot test: #700 (comment)

❓ Context

Impacted projects: ledger-live-desktop
Linked resource(s): FAT-99 FAT-556

✅ Checklist

Test coverage
Atomic delivery
No breaking changes

📸 Demo

TODO

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

vercel · 2022-07-20T15:29:03Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
live-common-tools	✅ Ready (Inspect)	Visit Preview	Oct 29, 2022 at 10:43AM (UTC)

3 Ignored Deployments

Name	Status	Updated
ledger-live-github-bot	⬜️ Ignored (Inspect)	Oct 29, 2022 at 10:43AM (UTC)
native-ui-storybook	⬜️ Ignored (Inspect)	Oct 29, 2022 at 10:43AM (UTC)
react-ui-storybook	⬜️ Ignored (Inspect)	Oct 29, 2022 at 10:43AM (UTC)

changeset-bot · 2022-07-20T15:29:03Z

🦋 Changeset detected

Latest commit: 9b5ebc4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
ledger-live-desktop	Minor
@ledgerhq/react-ui	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2022-07-20T15:44:02Z

screenshots test results: #700 (comment)

apps/ledger-live-desktop/src/renderer/components/SyncOnboarding/Manual/index.tsx

codecov · 2022-07-20T15:57:19Z

Codecov Report

Base: 0.00% // Head: 83.55% // Increases project coverage by +83.55% 🎉

Coverage data is based on head (86ebf0c) compared to base (34546ed).
Patch has no changes to coverable lines.

❗ Current head 86ebf0c differs from pull request most recent head 9b5ebc4. Consider uploading reports for the commit 9b5ebc4 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##           develop     #700       +/-   ##
============================================
+ Coverage         0   83.55%   +83.55%     
============================================
  Files            0       10       +10     
  Lines            0      906      +906     
  Branches         0      193      +193     
============================================
+ Hits             0      757      +757     
- Misses           0      142      +142     
- Partials         0        7        +7

Flag	Coverage Δ
test	`83.55% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...s/packages/hw-app-eth/src/services/ledger/erc20.ts	`93.44% <0.00%> (ø)`
...js/packages/hw-app-eth/src/modules/EIP712/index.ts	`99.24% <0.00%> (ø)`
...kages/hw-app-eth/src/services/ledger/loadConfig.ts	`100.00% <0.00%> (ø)`
...js/packages/hw-app-eth/src/services/ledger/nfts.ts	`12.50% <0.00%> (ø)`
libs/ledgerjs/packages/hw-app-eth/src/Eth.ts	`79.04% <0.00%> (ø)`
libs/ledgerjs/packages/hw-app-eth/src/errors.ts	`100.00% <0.00%> (ø)`
...ckages/hw-app-eth/src/services/ledger/contracts.ts	`82.60% <0.00%> (ø)`
...ages/hw-app-eth/src/modules/EIP712/EIP712.utils.ts	`93.75% <0.00%> (ø)`
libs/ledgerjs/packages/hw-app-eth/src/utils.ts	`92.59% <0.00%> (ø)`
...s/packages/hw-app-eth/src/services/ledger/index.ts	`83.87% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

ofreyssinet-ledger · 2022-10-28T16:57:24Z

/generate-screenshots 🤞 last hopeless try before the weekend that gh checkout runs fine in the macos runner

github-actions · 2022-10-28T17:32:24Z

@ofreyssinet-ledger

Generating screenshots: workflow ended:

Jobs status:
✅ - generate-screenshots-mac-internal
✅ - generate-screenshots (ubuntu-latest)
✅ - generate-screenshots (windows-latest)

ofreyssinet-ledger · 2022-10-29T10:07:52Z

/generate-screenshots

github-actions · 2022-10-29T10:08:08Z

@ofreyssinet-ledger

Generating screenshots: workflow ended:

Jobs status:
✅ - generate-screenshots-mac-internal
✅ - generate-screenshots (ubuntu-latest)
✅ - generate-screenshots (windows-latest)

github-actions bot assigned thomasrogerlux Jul 20, 2022

github-actions bot added the desktop Has changes in LLD label Jul 20, 2022

pierrelouis-c reviewed Jul 20, 2022

View reviewed changes

apps/ledger-live-desktop/src/renderer/components/SyncOnboarding/Manual/index.tsx Outdated Show resolved Hide resolved

pierrelouis-c force-pushed the feat/migrate-v3-onboarding branch from fb533d6 to aef0b87 Compare July 20, 2022 16:13

thomasrogerlux force-pushed the feat/FAT-99-desktop-sync-onboarding branch from d87a973 to b1cf4d7 Compare July 21, 2022 12:26

vercel bot deployed to Preview – live-common-tools July 21, 2022 12:27 View deployment

thomasrogerlux force-pushed the feat/FAT-99-desktop-sync-onboarding branch from b1cf4d7 to 6f1b59b Compare July 22, 2022 07:59

vercel bot deployed to Preview – live-common-tools July 22, 2022 08:00 View deployment

vercel bot deployed to Preview – live-common-tools July 22, 2022 14:09 View deployment

github-actions bot added the ui Has changes in the design system library label Jul 26, 2022

vercel bot deployed to Preview – react-ui-storybook July 26, 2022 08:05 View deployment

vercel bot deployed to Preview – live-common-tools July 26, 2022 08:06 View deployment

github-actions bot added the translations Translation files have been touched label Jul 26, 2022

vercel bot deployed to Preview – live-common-tools July 26, 2022 16:00 View deployment

vercel bot deployed to Preview – react-ui-storybook July 26, 2022 16:24 View deployment

vercel bot deployed to Preview – live-common-tools July 26, 2022 16:26 View deployment

pierrelouis-c force-pushed the feat/migrate-v3-onboarding branch from 933d3c9 to 5b2097a Compare July 27, 2022 14:24

thomasrogerlux force-pushed the feat/FAT-99-desktop-sync-onboarding branch from 4a82801 to 4ecf1c7 Compare July 27, 2022 14:36

vercel bot deployed to Preview – live-common-tools July 27, 2022 14:45 View deployment

pierrelouis-c force-pushed the feat/migrate-v3-onboarding branch 2 times, most recently from 7100c6c to 6b6b94e Compare August 4, 2022 08:19

thomasrogerlux force-pushed the feat/FAT-99-desktop-sync-onboarding branch from 4ecf1c7 to ae9a5b3 Compare August 4, 2022 15:21

vercel bot deployed to Preview – live-common-tools August 4, 2022 15:22 View deployment

vercel bot deployed to Preview – live-common-tools August 4, 2022 15:39 View deployment

vercel bot deployed to Preview – live-common-tools August 5, 2022 13:29 View deployment

vercel bot deployed to Preview – live-common-tools August 8, 2022 15:41 View deployment

ofreyssinet-ledger closed this Oct 28, 2022

ofreyssinet-ledger reopened this Oct 28, 2022

update screenshots (ubuntu-latest)

6d37887

vercel bot deployed to Preview – live-common-tools October 28, 2022 17:20 View deployment

update screenshots (windows-latest)

ebe1a69

vercel bot deployed to Preview – live-common-tools October 28, 2022 17:31 View deployment

update screenshots (ubuntu-latest)

21d0aeb

vercel bot deployed to Preview – live-common-tools October 28, 2022 17:59 View deployment

update screenshots (windows-latest)

1ddb8c8

vercel bot deployed to Preview – live-common-tools October 28, 2022 18:10 View deployment

update screenshots (macos-latest)

b0188d1

vercel bot deployed to Preview – live-common-tools October 28, 2022 18:57 View deployment

pierrelouis-c closed this Oct 29, 2022

pierrelouis-c reopened this Oct 29, 2022

remove flaky screenshot in manager

86ebf0c

vercel bot deployed to Preview – live-common-tools October 29, 2022 10:08 View deployment

update screenshots (ubuntu-latest)

261dd4e

vercel bot deployed to Preview – live-common-tools October 29, 2022 10:29 View deployment

update screenshots (macos-latest)

aeb35c5

vercel bot deployed to Preview – live-common-tools October 29, 2022 10:32 View deployment

update screenshots (windows-latest)

64127a1

vercel bot deployed to Preview – live-common-tools October 29, 2022 10:40 View deployment

empty commit

9b5ebc4

vercel bot deployed to Preview – live-common-tools October 29, 2022 10:43 View deployment

ofreyssinet-ledger merged commit bf9e7a2 into develop Oct 29, 2022

ofreyssinet-ledger deleted the feat/FAT-99-desktop-sync-onboarding branch October 29, 2022 11:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Synchronous onboarding and PostOnboarding on Desktop #700

Synchronous onboarding and PostOnboarding on Desktop #700

thomasrogerlux commented Jul 20, 2022 •

edited by ofreyssinet-ledger

Loading

vercel bot commented Jul 20, 2022 •

edited

Loading

changeset-bot bot commented Jul 20, 2022 •

edited

Loading

github-actions bot commented Jul 20, 2022 •

edited by ofreyssinet-ledger

Loading

codecov bot commented Jul 20, 2022 •

edited

Loading

ofreyssinet-ledger commented Oct 28, 2022

github-actions bot commented Oct 28, 2022 •

edited

Loading

ofreyssinet-ledger commented Oct 29, 2022

github-actions bot commented Oct 29, 2022 •

edited

Loading

Synchronous onboarding and PostOnboarding on Desktop #700

Synchronous onboarding and PostOnboarding on Desktop #700

Conversation

thomasrogerlux commented Jul 20, 2022 • edited by ofreyssinet-ledger Loading

📝 Description

❓ Context

✅ Checklist

📸 Demo

🚀 Expectations to reach

vercel bot commented Jul 20, 2022 • edited Loading

changeset-bot bot commented Jul 20, 2022 • edited Loading

🦋 Changeset detected

github-actions bot commented Jul 20, 2022 • edited by ofreyssinet-ledger Loading

codecov bot commented Jul 20, 2022 • edited Loading

Codecov Report

ofreyssinet-ledger commented Oct 28, 2022

github-actions bot commented Oct 28, 2022 • edited Loading

ofreyssinet-ledger commented Oct 29, 2022

github-actions bot commented Oct 29, 2022 • edited Loading

thomasrogerlux commented Jul 20, 2022 •

edited by ofreyssinet-ledger

Loading

vercel bot commented Jul 20, 2022 •

edited

Loading

changeset-bot bot commented Jul 20, 2022 •

edited

Loading

github-actions bot commented Jul 20, 2022 •

edited by ofreyssinet-ledger

Loading

codecov bot commented Jul 20, 2022 •

edited

Loading

github-actions bot commented Oct 28, 2022 •

edited

Loading

github-actions bot commented Oct 29, 2022 •

edited

Loading