Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LIVE-11438][LIVE-11670] Remove feature flags "supportDeviceStax" and "staxWelcomeScreen" #7006

Merged
merged 5 commits into from
Jun 10, 2024
Merged

[LIVE-11438][LIVE-11670] Remove feature flags "supportDeviceStax" and "staxWelcomeScreen" #7006

merged 5 commits into from
Jun 10, 2024

Conversation

ofreyssinet-ledger
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger commented Jun 4, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Support of Stax is always enabled in LLM and LLD.
    • The video on the welcome screen of LLM is always the Stax video.
    • The feature flag group "stax" does not exist anymore.

📝 Description

Cleanup of feature flags that have been activated in production.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@ofreyssinet-ledger ofreyssinet-ledger requested review from a team as code owners June 4, 2024 08:29
@vercel Vercel
Copy link

vercel bot commented Jun 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 10:36am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 10:36am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 10:36am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 10:36am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2024 10:36am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Jun 4, 2024
@ofreyssinet-ledger
Copy link
Contributor Author

ofreyssinet-ledger commented Jun 4, 2024 •
edited by live-github-bot bot
Loading

@ofreyssinet-ledger

Generating screenshots: workflow ended

Jobs status:
✅ - generate-screenshots-linux

@live-github-bot live-github-bot bot added the screenshots Screenshots have been updated label Jun 4, 2024
mcayuelas-ledger
mcayuelas-ledger previously approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Hub

@ofreyssinet-ledger ofreyssinet-ledger force-pushed the feat/cleanup-stax-feature-flags branch 2 times, most recently from 4c52d7b to 497425b Compare June 7, 2024 09:35
valber-ledger
valber-ledger approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@valber-ledger valber-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just checked QAA files

@ofreyssinet-ledger ofreyssinet-ledger merged commit 3a81b27 into develop Jun 10, 2024
58 checks passed
@ofreyssinet-ledger ofreyssinet-ledger deleted the feat/cleanup-stax-feature-flags branch June 10, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valpinkman valpinkman valpinkman approved these changes

@valber-ledger valber-ledger valber-ledger approved these changes

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger left review comments

Assignees

@ofreyssinet-ledger ofreyssinet-ledger

Labels
common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM screenshots Screenshots have been updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ofreyssinet-ledger @valpinkman @mcayuelas-ledger @valber-ledger