Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enforce only one version of styled components on dev mode #7010

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented Jun 4, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

We need to enforce only one version of styled components on dev mode for LLD.
Otherwise we cannot resolve the theme correctly depending on where we are on our stack (LLD/react-ui/icons)
Without it we do have issue with our theme

image
image

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@KVNLS KVNLS requested a review from a team as a code owner June 4, 2024 13:39
Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Jun 4, 2024 1:39pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Jun 4, 2024 1:39pm
native-ui-storybook ⬜️ Ignored (Inspect) Jun 4, 2024 1:39pm
react-ui-storybook ⬜️ Ignored (Inspect) Jun 4, 2024 1:39pm
web-tools ⬜️ Ignored (Inspect) Jun 4, 2024 1:39pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jun 4, 2024
@KVNLS KVNLS merged commit bc92d16 into develop Jun 4, 2024
35 checks passed
@KVNLS KVNLS deleted the fix/styled-components-lld branch June 4, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants