Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: LLD Stax post onboarding text color light mode #7012

Merged
merged 1 commit into from
Jun 4, 2024
Merged

fix: LLD Stax post onboarding text color light mode #7012

merged 1 commit into from
Jun 4, 2024

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented Jun 4, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Fix text color for Stax post onboarding on light mode.

Before
image

After
image

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@KVNLS KVNLS self-assigned this Jun 4, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 3:17pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 3:17pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 3:17pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 3:17pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 4, 2024 3:17pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jun 4, 2024
@KVNLS KVNLS marked this pull request as ready for review June 4, 2024 15:44
@KVNLS KVNLS requested a review from a team as a code owner June 4, 2024 15:44
@KVNLS KVNLS merged commit 4b3e5b0 into develop Jun 4, 2024
35 of 39 checks passed
@KVNLS KVNLS deleted the fix/live-12291 branch June 4, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrellard-ledger cgrellard-ledger cgrellard-ledger approved these changes

Assignees

@KVNLS KVNLS

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KVNLS @cgrellard-ledger