Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LIVE-12325] Remove remaining manager v1 api calls (outside of list apps v1) #7019

Merged
merged 9 commits into from
Jun 12, 2024
Merged

[LIVE-12325] Remove remaining manager v1 api calls (outside of list apps v1) #7019

merged 9 commits into from
Jun 12, 2024

Conversation

ofreyssinet-ledger
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger commented Jun 5, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • cf. description

📝 Description

  • device-core / live-common: Create getAppsCatalogForDevice use case
  • live-common: Refactor "app update available" logic to only rely on v2 manager apis (using getAppsCatalogForDevice use case)
  • web-tools, CLI: Refactor install/uninstall app commands to only rely on v2 manager apis (using getAppsCatalogForDevice use case)

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Jun 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 9:49am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 9:49am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 9:49am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 9:49am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 12, 2024 9:49am

@live-github-bot live-github-bot bot added common Has changes in live-common cli desktop Has changes in LLD labels Jun 5, 2024
@ofreyssinet-ledger ofreyssinet-ledger force-pushed the bugfix/LIVE-12325-remove-manager-v1-api-calls branch from a990500 to 8d05e65 Compare June 5, 2024 16:12
@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Jun 5, 2024
ofreyssinet-ledger
ofreyssinet-ledger commented Jun 7, 2024
View reviewed changes
libs/ledger-live-common/src/manager/useAvailableLanguagesForDevice.ts Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just extracted as-is from hooks.ts

ofreyssinet-ledger
ofreyssinet-ledger commented Jun 7, 2024
View reviewed changes
libs/ledger-live-common/src/manager/useDeviceHasUpdatesAvailable.ts Outdated
Copy link
Contributor Author

@ofreyssinet-ledger ofreyssinet-ledger Jun 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extracted from hooks.ts and refactored to rely on getAppsCatalogForDevice instead of the old list apps API

@ofreyssinet-ledger ofreyssinet-ledger force-pushed the bugfix/LIVE-12325-remove-manager-v1-api-calls branch from c300e84 to bdf92ee Compare June 10, 2024 09:32
@ofreyssinet-ledger ofreyssinet-ledger marked this pull request as ready for review June 10, 2024 09:39
@ofreyssinet-ledger ofreyssinet-ledger requested review from a team as code owners June 10, 2024 09:39
gre
gre previously approved these changes Jun 11, 2024
View reviewed changes
valpinkman
valpinkman previously approved these changes Jun 11, 2024
View reviewed changes
@ofreyssinet-ledger ofreyssinet-ledger dismissed stale reviews from valpinkman and gre via 383baeb June 11, 2024 09:53
@ofreyssinet-ledger ofreyssinet-ledger force-pushed the bugfix/LIVE-12325-remove-manager-v1-api-calls branch from bdf92ee to 383baeb Compare June 11, 2024 09:53
@ofreyssinet-ledger ofreyssinet-ledger force-pushed the bugfix/LIVE-12325-remove-manager-v1-api-calls branch from 383baeb to f7b51d8 Compare June 12, 2024 09:44
@ofreyssinet-ledger ofreyssinet-ledger merged commit ef00813 into develop Jun 12, 2024
56 of 58 checks passed
@ofreyssinet-ledger ofreyssinet-ledger deleted the bugfix/LIVE-12325-remove-manager-v1-api-calls branch June 12, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gre gre gre approved these changes

@aussedatlo aussedatlo aussedatlo approved these changes

@jdabbech-ledger jdabbech-ledger jdabbech-ledger approved these changes

@valpinkman valpinkman valpinkman left review comments

Assignees

@ofreyssinet-ledger ofreyssinet-ledger

Labels
cli common Has changes in live-common desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ofreyssinet-ledger @gre @valpinkman @aussedatlo @jdabbech-ledger