Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(live-12813): remove the swap webview conditional for demo0 #7022

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

liviuciulinaru
Copy link
Contributor

@liviuciulinaru liviuciulinaru commented Jun 6, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

remove the swap webview conditional for demo0

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

https://ledgerhq.atlassian.net/browse/LIVE-12813

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@liviuciulinaru liviuciulinaru requested a review from a team as a code owner June 6, 2024 08:19
Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2024 10:00am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2024 10:00am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2024 10:00am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2024 10:00am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 6, 2024 10:00am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jun 6, 2024
kallen-ledger
kallen-ledger previously approved these changes Jun 6, 2024
@liviuciulinaru liviuciulinaru force-pushed the fix/live-12813/swap-btn-disavled-demo0 branch from 6b1ebea to d51b5f0 Compare June 6, 2024 09:41
@cng-ledger cng-ledger merged commit 1953578 into develop Jun 6, 2024
34 checks passed
@cng-ledger cng-ledger deleted the fix/live-12813/swap-btn-disavled-demo0 branch June 6, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants