Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sourceCurrencyId and targetCurrencyId #7031

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

lpaquet-ledger
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Remove sourceCurrencyId and targetCurrencyId sending wrong info

❓ Context

https://ledgerhq.atlassian.net/browse/LIVE-12808


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@lpaquet-ledger lpaquet-ledger requested a review from a team as a code owner June 7, 2024 08:17
Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Jun 7, 2024 8:17am
ledger-live-github-bot ⬜️ Ignored (Inspect) Jun 7, 2024 8:17am
native-ui-storybook ⬜️ Ignored (Inspect) Jun 7, 2024 8:17am
react-ui-storybook ⬜️ Ignored (Inspect) Jun 7, 2024 8:17am
web-tools ⬜️ Ignored (Inspect) Jun 7, 2024 8:17am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Jun 7, 2024
@lpaquet-ledger lpaquet-ledger merged commit 0cafb0f into develop Jun 7, 2024
38 checks passed
@lpaquet-ledger lpaquet-ledger deleted the feat/LIVE-12808 branch June 7, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants