Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] : Manage instances in LLD #7038

Merged
merged 58 commits into from
Jun 11, 2024
Merged

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Jun 7, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

  • Manage instances in LLD
  • Rework of Steps
Screen.Recording.2024-06-10.at.10.07.59.mov
Screenshot 2024-06-07 at 18 17 11

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 8:58am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 8:58am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 8:58am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 8:58am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 8:58am

@live-github-bot live-github-bot bot added desktop Has changes in LLD ui Has changes in the design system library translations Translation files have been touched labels Jun 7, 2024
@mcayuelas-ledger mcayuelas-ledger changed the base branch from develop to feat/ws-synchronize-lld June 7, 2024 15:57
@live-github-bot live-github-bot bot removed the ui Has changes in the design system library label Jun 7, 2024
mcayuelas-ledger and others added 16 commits June 10, 2024 17:25
Reorg in new arch
* remove useless files

* remove useless files

* ⚑[FEAT]: WS Manage your Backup in LLD

* changeset

* Add Loading + error screen

* Add Integration test

* Reworks steps

* Add unsecured Error

* fix WS tests

* update flow

* fix path

* Fix tests

* transition between flows

* Add test for useFlow

* add ManageBackup analytics

* Fix reset flow

* Mock Analytics

---------

Co-authored-by: Maxime Aubanel <[email protected]>
@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner June 10, 2024 15:27
KVNLS
KVNLS previously approved these changes Jun 11, 2024
Copy link
Member

@KVNLS KVNLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from feat/ws-activation-flow-lld to develop June 11, 2024 08:00
@mcayuelas-ledger mcayuelas-ledger dismissed KVNLS’s stale review June 11, 2024 08:00

The base branch was changed.

@cgrellard-ledger cgrellard-ledger merged commit 0e5b042 into develop Jun 11, 2024
32 of 34 checks passed
@cgrellard-ledger cgrellard-ledger deleted the feat/manage-instances-LLD branch June 11, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants