Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lld): camera does not shut off when not scanning qr code #7043

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Jun 10, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • QR code scan

πŸ“ Description

When "scan qr code" pop up on send flow is opened then closed the video stream isn't stopped.
To avoid this we cut off the stream once the pop up gets unmounted or if a qr code has been well scanned.

Before After
https://github.com/LedgerHQ/ledger-live/assets/73439207/486a7eb3-8a7a-4c85-a762-5457f14113b4 https://github.com/LedgerHQ/ledger-live/assets/73439207/f9033832-70d8-4cc8-b8e8-2455472e66ae

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner June 10, 2024 10:01
Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Jun 10, 2024 10:01am
ledger-live-github-bot ⬜️ Ignored (Inspect) Jun 10, 2024 10:01am
native-ui-storybook ⬜️ Ignored (Inspect) Jun 10, 2024 10:01am
react-ui-storybook ⬜️ Ignored (Inspect) Jun 10, 2024 10:01am
web-tools ⬜️ Ignored (Inspect) Jun 10, 2024 10:01am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jun 10, 2024
@LucasWerey LucasWerey merged commit 117aca7 into develop Jun 10, 2024
35 of 41 checks passed
@LucasWerey LucasWerey deleted the fix/LIVE-12938 branch June 10, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants