Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› [BUGFIX] : Add Fallback for Market Widget Crypto icons #7044

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Jun 10, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Backend could encounter issues and images would not load.

A fallback is to be created where we put the letter of the crypto in the image location
Screenshot 2024-06-10 at 12 01 34

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner June 10, 2024 10:02
Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Jun 10, 2024 10:02am
ledger-live-github-bot ⬜️ Ignored (Inspect) Jun 10, 2024 10:02am
native-ui-storybook ⬜️ Ignored (Inspect) Jun 10, 2024 10:02am
react-ui-storybook ⬜️ Ignored (Inspect) Jun 10, 2024 10:02am
web-tools ⬜️ Ignored (Inspect) Jun 10, 2024 10:02am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jun 10, 2024
@mcayuelas-ledger mcayuelas-ledger merged commit c1b405b into develop Jun 10, 2024
34 of 37 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the bugfix/fallback-market-widget branch June 10, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants