Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVE-12403] [LLM] πŸ› Issue if Stax loses connection with LLM during firmware upgrade #7050

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

jdabbech-ledger
Copy link
Contributor

@jdabbech-ledger jdabbech-ledger commented Jun 10, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Fix issue if Stax loses connection with LLM during firmware upgrade

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@jdabbech-ledger jdabbech-ledger requested a review from a team as a code owner June 10, 2024 14:04
Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Jun 10, 2024 2:04pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Jun 10, 2024 2:04pm
native-ui-storybook ⬜️ Ignored (Inspect) Jun 10, 2024 2:04pm
react-ui-storybook ⬜️ Ignored (Inspect) Jun 10, 2024 2:04pm
web-tools ⬜️ Ignored (Inspect) Jun 10, 2024 2:04pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Jun 10, 2024
Copy link
Member

@KVNLS KVNLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These hooks and components would benefit from a refactor in the future, we do so much in them. 🀯

@jdabbech-ledger jdabbech-ledger merged commit 52745cc into develop Jun 11, 2024
37 of 44 checks passed
@jdabbech-ledger jdabbech-ledger deleted the fix/LIVE-12403-stax-lock-fw-update branch June 11, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants