Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(llm): add settings row for wallet sync #7051

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Jun 10, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • General Settings

πŸ“ Description

Add wallet sync entry point inside settings/generals
The row won't be displayed as the ff llmWalletSync is not enabled
For the moment this row won't redirect anywhere

llmWalletSync disabled llmWalletSync enabled
Screenshot 2024-06-10 at 16 26 08 Screenshot 2024-06-10 at 16 19 49

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner June 10, 2024 14:22
Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Jun 10, 2024 2:22pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Jun 10, 2024 2:22pm
native-ui-storybook ⬜️ Ignored (Inspect) Jun 10, 2024 2:22pm
react-ui-storybook ⬜️ Ignored (Inspect) Jun 10, 2024 2:22pm
web-tools ⬜️ Ignored (Inspect) Jun 10, 2024 2:22pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Jun 10, 2024
@LucasWerey LucasWerey merged commit bdaf29e into develop Jun 11, 2024
41 of 46 checks passed
@LucasWerey LucasWerey deleted the feat/LIVE-12246 branch June 11, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants