Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(llm): add wallet sync entry point during onboarding #7055

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Jun 11, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • OnBoarding

📝 Description

During the onboarding user will have the possibility to sync LLM using wallet sync.
A dummy drawer has been created to simulate the future one.
Onboarding entry point is hidden behind a ff

Fix a little prop that was missing too for the rows

Screenshot 2024-06-11 at 09 39 50 Screenshot 2024-06-11 at 09 39 52

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner June 11, 2024 07:38
Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 8:20am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 8:20am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 8:20am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 8:20am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 8:20am

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Jun 11, 2024
@LucasWerey LucasWerey merged commit 04ae377 into develop Jun 11, 2024
36 of 37 checks passed
@LucasWerey LucasWerey deleted the feat/LIVE-12194 branch June 11, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants