Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle cta click on Storyly LLM #7063

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Handle cta click on Storyly LLM #7063

merged 1 commit into from
Jun 12, 2024

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented Jun 11, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Fix cta click inside stories on LLM

swap_llm.mp4

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@KVNLS KVNLS self-assigned this Jun 11, 2024
@KVNLS KVNLS requested a review from a team as a code owner June 11, 2024 13:54
Copy link

vercel bot commented Jun 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 1:58pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 1:58pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 1:58pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 1:58pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 1:58pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Jun 11, 2024
@KVNLS KVNLS merged commit f08f0b9 into develop Jun 12, 2024
37 checks passed
@KVNLS KVNLS deleted the fix/live-12976 branch June 12, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants