Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(llm): new add account drawer on assets screen with WS entrypoint #7064

Merged
merged 10 commits into from
Jun 19, 2024
Merged

feat(llm): new add account drawer on assets screen with WS entrypoint #7064

merged 10 commits into from
Jun 19, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Jun 11, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Add account drawer
    • Portfolio
    • Empty portfolio
    • ReadOnly portfolio
    • Assets screen
    • Accounts screen

📝 Description

Create a new drawer component on add account. This new drawer has new UI and an entry point to walletSync. This entrypoint is hidden under a feature flag. Also update translations related to WS.
Some adjustments have been added to make integration tests work

Screenshot 2024-06-18 at 17 04 04

TODO:

  • Change translation variables names
  • E2E test
  • Integrations Tests
Feature Flag off Feature flag on
https://github.com/LedgerHQ/ledger-live/assets/73439207/32ce6c7a-d3e5-4c43-815a-3fb6ec37570b https://github.com/LedgerHQ/ledger-live/assets/73439207/7fad31ab-491f-418d-a47c-8e4b444c8e5d

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Jun 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 3:49pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 3:49pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 3:49pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 3:49pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 18, 2024 3:49pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Jun 11, 2024
@LucasWerey LucasWerey added the WIP Work in progress label Jun 11, 2024
@LucasWerey LucasWerey force-pushed the feat/LIVE-12195 branch 2 times, most recently from d58c323 to 525a6e1 Compare June 12, 2024 07:56
@LucasWerey LucasWerey marked this pull request as ready for review June 12, 2024 09:34
@LucasWerey LucasWerey requested a review from a team as a code owner June 12, 2024 09:34
@LucasWerey LucasWerey removed the WIP Work in progress label Jun 12, 2024
KVNLS
KVNLS reviewed Jun 13, 2024
View reviewed changes
apps/ledger-live-mobile/src/newArch/features/WalletSync/drawers/addAccount/index.tsx Outdated
@@ -0,0 +1,93 @@
/* eslint-disable @typescript-eslint/no-unused-vars */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we follow the guidelines we can't add a drawers folder here.
We should put AddAccount (PascalCase) under screens or components folder.
https://ledgerhq.atlassian.net/wiki/spaces/WXP/pages/4508058220/Code+Guidelines+-+React+Native#Folder-organization

mcayuelas-ledger
mcayuelas-ledger reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LucasWerey LucasWerey force-pushed the feat/LIVE-12195 branch 2 times, most recently from 896736a to e76560a Compare June 17, 2024 16:58
gre
gre approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@gre gre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@LucasWerey LucasWerey merged commit 93de715 into develop Jun 19, 2024
38 of 39 checks passed
@LucasWerey LucasWerey deleted the feat/LIVE-12195 branch June 19, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KVNLS KVNLS KVNLS left review comments

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger left review comments

@gre gre gre approved these changes

Assignees

@LucasWerey LucasWerey

Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LucasWerey @gre @KVNLS @mcayuelas-ledger