Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(PROTECT-3160): add dev mode to analytics #7091

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

cksanders
Copy link
Contributor

@cksanders cksanders commented Jun 13, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • All analytics events will now receive the devModeEnabled value as a property, this property will be sent to the Recover Live App

📝 Description

It is valuable to be able to exclude all users/events in Dev Mode in our insights/funnels etc. and ultimately ensure we only track real users.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cksanders cksanders requested review from a team as code owners June 13, 2024 13:32
Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 13, 2024 2:17pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 13, 2024 2:17pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 13, 2024 2:17pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 13, 2024 2:17pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 13, 2024 2:17pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Jun 13, 2024
KVNLS
KVNLS previously approved these changes Jun 13, 2024
Copy link
Member

@KVNLS KVNLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Justkant
Justkant previously approved these changes Jun 13, 2024
@cksanders cksanders dismissed stale reviews from Justkant and KVNLS via 5e88a7f June 13, 2024 14:16
@cksanders cksanders force-pushed the chore/PROTECT-3160/add-dev-mode branch from 78643b5 to 5e88a7f Compare June 13, 2024 14:16
@cksanders cksanders merged commit e0c89dc into develop Jun 13, 2024
55 of 56 checks passed
@cksanders cksanders deleted the chore/PROTECT-3160/add-dev-mode branch June 13, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants