Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/prevent empty trc20 swap #7094

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Conversation

CremaFR
Copy link
Member

@CremaFR CremaFR commented Jun 13, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Prevent TRC20 swaps in tron account does not have 0,1TRX

❓ Context

- JIRA or GitHub link:


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@CremaFR CremaFR requested review from a team as code owners June 13, 2024 14:52
Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Jun 13, 2024 2:52pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Jun 13, 2024 2:52pm
native-ui-storybook ⬜️ Ignored (Inspect) Jun 13, 2024 2:52pm
react-ui-storybook ⬜️ Ignored (Inspect) Jun 13, 2024 2:52pm
web-tools ⬜️ Ignored (Inspect) Jun 13, 2024 2:52pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched labels Jun 13, 2024
@CremaFR CremaFR merged commit 785c618 into develop Jun 17, 2024
58 of 61 checks passed
@CremaFR CremaFR deleted the bugfix/prevent-empty-trc20-swap branch June 17, 2024 08:48
kallen-ledger pushed a commit that referenced this pull request Jun 26, 2024
* bugfix: prevent TRC20 swap if empty account

* chore: changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants