Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ptx mixpanel attributes #7106

Merged
merged 4 commits into from
Jun 17, 2024
Merged

feat: ptx mixpanel attributes #7106

merged 4 commits into from
Jun 17, 2024

Conversation

cng-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Track extra PTX attributes for Mixpanel

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@cng-ledger cng-ledger requested a review from a team as a code owner June 14, 2024 13:26
@vercel Vercel
Copy link

vercel bot commented Jun 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 17, 2024 5:57am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 17, 2024 5:57am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 17, 2024 5:57am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 17, 2024 5:57am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 17, 2024 5:57am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jun 14, 2024
CremaFR
CremaFR previously approved these changes Jun 14, 2024
View reviewed changes
LucasWerey
LucasWerey previously approved these changes Jun 14, 2024
View reviewed changes
@cng-ledger cng-ledger dismissed stale reviews from LucasWerey and CremaFR via 755437b June 17, 2024 05:56
@cng-ledger cng-ledger merged commit aab1636 into develop Jun 17, 2024
34 checks passed
@cng-ledger cng-ledger deleted the feat/ptx-mixpanel-attributes branch June 17, 2024 07:37
kallen-ledger pushed a commit that referenced this pull request Jun 26, 2024
@cng-ledger @kallen-ledger
feat: ptx mixpanel attributes (#7106)
3049a24 
* feat: tracking ptx analytics attributes

* feat: changeset

* feat: rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasWerey LucasWerey LucasWerey approved these changes

@CremaFR CremaFR Awaiting requested review from CremaFR

Assignees

@cng-ledger cng-ledger

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cng-ledger @CremaFR @LucasWerey