Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Bugfix - XRP custom UI missing #7109

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

lambertkevin
Copy link
Contributor

@lambertkevin lambertkevin commented Jun 15, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Brings back custom UI for XRP transfers

📝 Description

XRP custom UIs in clients were removed by mistake due to the renaming of the family from ripple to xrp. This brings them back.

Enregistrement.de.l.ecran.2024-06-15.a.16.35.55.mov
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-06-15.at.16.31.59.mp4

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@lambertkevin lambertkevin requested a review from a team as a code owner June 15, 2024 14:42
Copy link

vercel bot commented Jun 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Jun 15, 2024 2:42pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Jun 15, 2024 2:42pm
native-ui-storybook ⬜️ Ignored (Inspect) Jun 15, 2024 2:42pm
react-ui-storybook ⬜️ Ignored (Inspect) Jun 15, 2024 2:42pm
web-tools ⬜️ Ignored (Inspect) Jun 15, 2024 2:42pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Jun 15, 2024
Copy link
Contributor

@ComradeAERGO ComradeAERGO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lambertkevin lambertkevin merged commit 9707d0d into release Jun 17, 2024
52 of 60 checks passed
@lambertkevin lambertkevin deleted the bugfix/xrp-custom-ui-missing branch June 17, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants