Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVE-12976] LLM - Fix Storyly close action #7111

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented Jun 17, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

This PR fix two issues:

  • When you navigate by clicking into a cta in a Story, the Story is still considered as opened , so when you come back and try to open it again, nothing happens
  • When you open a story and touch on the left on the screen, the story is closed as there are no previous story, then the story is not considered as closed and we fall into the same issue as the first one.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@KVNLS KVNLS self-assigned this Jun 17, 2024
@KVNLS KVNLS requested a review from a team as a code owner June 17, 2024 06:34
Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Jun 17, 2024 6:34am
ledger-live-github-bot ⬜️ Ignored (Inspect) Jun 17, 2024 6:34am
native-ui-storybook ⬜️ Ignored (Inspect) Jun 17, 2024 6:34am
react-ui-storybook ⬜️ Ignored (Inspect) Jun 17, 2024 6:34am
web-tools ⬜️ Ignored (Inspect) Jun 17, 2024 6:34am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Jun 17, 2024
@KVNLS KVNLS merged commit 221ca5a into develop Jun 17, 2024
32 of 38 checks passed
@KVNLS KVNLS deleted the fix/storyly-close-with-previous branch June 17, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants