Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(llm/lld): change analytics opt-in translations #7115

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Jun 17, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Analytics translations
    • opt-in prompt

📝 Description

Change the descriptions for Variant A of analytics opt-in prompt
This needed some little UI adjustments so text in LLM fits inside the screen.

New translations : 

LLD & LLM Variant A ONLY: 

First opt-in prompt screen : 

Analytics : “To measure the performance of Ledger Live and enhance both the app and your experience (Analytics).”

Personalization : “To provide you with personalized recommendations and content tailored to your preferences, as well as to help us measure the effectiveness of our marketing campaigns (Personalization).”

Second opt-in prompt screen : 

Analytics: “To measure Ledger Live’s performance and improve both the app and your experience, we share usage data, including page visits and clicks.”

Personalization: “To receive personalized recommendations and content that match your preferences and to help us measure the performance of our marketing campaigns, we share app usage data, including clicks, page visits, and conversion data.”

Settings screen :

Analytics : “Enable Ledger to track app usage data to help measure Ledger Live’s performance and enhance both the app and your experience.”

Personalization : “Enable Ledger to track app usage data to provide personalized recommendations and content that match your preferences and to help measure the performance of our marketing campaigns.”

LLM LLD
Screenshot 2024-06-17 at 12 17 18 Screenshot 2024-06-17 at 12 24 38
Screenshot 2024-06-17 at 12 17 21 Screenshot 2024-06-17 at 12 24 40
Screenshot 2024-06-17 at 12 17 33 Screenshot 2024-06-17 at 12 19 44

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner June 17, 2024 09:50
Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Jun 17, 2024 9:50am
ledger-live-github-bot ⬜️ Ignored (Inspect) Jun 17, 2024 9:50am
native-ui-storybook ⬜️ Ignored (Inspect) Jun 17, 2024 9:50am
react-ui-storybook ⬜️ Ignored (Inspect) Jun 17, 2024 9:50am
web-tools ⬜️ Ignored (Inspect) Jun 17, 2024 9:50am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched labels Jun 17, 2024
Copy link
Member

@KVNLS KVNLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LucasWerey LucasWerey merged commit 9c36cf8 into develop Jun 17, 2024
50 of 61 checks passed
@LucasWerey LucasWerey deleted the fix/LIVE-13030 branch June 17, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants