Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Hotfix 2024-06-20 #7153

Merged
merged 6 commits into from
Jun 24, 2024
Merged

🔥 Hotfix 2024-06-20 #7153

merged 6 commits into from
Jun 24, 2024

Conversation

live-github-bot[bot]
Copy link
Contributor

Next release is on the way 🚀!

This pull request aims to fix a bug in production for a Ledger Live product.

Checklist

To be ready to be merged, we must comply with all theses checks:

  • changelogs are included with description about the bug(s)
  • all CI checks have passed
  • reviewed by QA
  • hotix is reviewed by the Delivery Team

⚠️ If this hotfix targets Ledger Live Desktop

  • RELEASE_NOTES.md has been updated

Once all these checks are validated, the pull request can be merged using the correct workflow.

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2024 3:14pm
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 3:14pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 3:14pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 3:14pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 24, 2024 3:14pm

* getAddress support

* fix: add metadata support

* fix: get polkadot app version

* fix: refactoring

* fix: refactoring

* fix: refactoring

* fix: refactoring

* fix: small refactoring

* fix: update doc

* feat: add Polkadot coin configuration

Signed-off-by: Stéphane Prohaszka <[email protected]>

* polkadot config location

* fix: polkadot transaction craft

* remove useless code

* fix: refactoring

* fix: runtime upgrade transaction

* fix: update doc

* fix: unit tests

* fix: update changelog

* fix: update pnpm-lock

* fix: update polkadot integration test APDU

---------

Signed-off-by: Stéphane Prohaszka <[email protected]>
Co-authored-by: hzheng-ledger <[email protected]>
Co-authored-by: Stéphane Prohaszka <[email protected]>
Co-authored-by: lvndry <[email protected]>
@hzheng-ledger hzheng-ledger requested a review from a team as a code owner June 20, 2024 12:59
@live-github-bot live-github-bot bot added common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Jun 20, 2024
@live-github-bot live-github-bot bot requested review from a team as code owners June 20, 2024 13:07
@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM cli labels Jun 20, 2024
@live-github-bot
Copy link
Contributor Author

live-github-bot bot commented Jun 20, 2024

Desktop Bundle Checks

Comparing e033fe4 against a27c42b.

⚠️ @zondax/ledger-js library is now duplicated in renderer (regression)
🚀 @polkadot/networks library is no longer duplicated in renderer

Mobile Bundle Checks

Comparing e033fe4 against a27c42b.

@live-github-bot live-github-bot bot merged commit 2614225 into main Jun 24, 2024
2 of 7 checks passed
@live-github-bot live-github-bot bot deleted the hotfix branch June 24, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants