Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lld): fix countervalues release #7154

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix(lld): fix countervalues release #7154

merged 1 commit into from
Jun 20, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Jun 20, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Fix pre release problem about counter values. Also fix an UI error on accounts

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner June 20, 2024 12:40
Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2024 0:41am
ledger-live-github-bot ⬜️ Ignored (Inspect) Jun 20, 2024 0:41am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2024 0:41am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2024 0:41am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2024 0:41am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jun 20, 2024
@LucasWerey LucasWerey changed the title hotfix(lld): fix countervalues fix(lld): fix countervalues Jun 20, 2024
@LucasWerey LucasWerey changed the title fix(lld): fix countervalues fix(lld): fix countervalues release Jun 20, 2024
@LucasWerey LucasWerey merged commit f8fe567 into release Jun 20, 2024
33 of 41 checks passed
@LucasWerey LucasWerey deleted the fix/LIVE-13072 branch June 20, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants