Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [LIVE-12734] [LLD] Device disconnect during restore apps on LNX causing the app restore to fail #7157

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

jdabbech-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Investigations for this bug:

  • An old apdu e0500000, which is bad formatted, was sent to the device (https://ledgerhq.atlassian.net/browse/LIVE-5273), we chose to delete it as it has no impact to get device/set device on LLM or LLD
  • the firmware update bring a device disconnection on next allow manager, but only with a language pack install. Caused by e053000000 APDU

After several tests that leaded to random behaviors, a trivial solution was to reset the dashboard with the app restauration list after disconnection.

❓ Context

  • JIRA or GitHub link: []LIVE-12734]

🧐 Checklist for the PR Reviewers

live-12734.mp4
  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@jdabbech-ledger jdabbech-ledger requested a review from a team as a code owner June 20, 2024 16:03
Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2024 9:22am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2024 9:22am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2024 9:22am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2024 9:22am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 21, 2024 9:22am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jun 20, 2024
@jdabbech-ledger jdabbech-ledger force-pushed the bugfix/LIVE-12734-fw-update-language-pack branch from d92bdc9 to 38a18fd Compare June 21, 2024 09:21
@jdabbech-ledger jdabbech-ledger requested review from a team as code owners June 21, 2024 09:21
@live-github-bot live-github-bot bot added mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs cli labels Jun 21, 2024
@ledger-wiz-cspm-secret-detection

Wiz Scan Summary

IaC Misconfigurations 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 4L 0I
Total 0C 0H 0M 4L 0I
Secrets 0🔑

@jdabbech-ledger jdabbech-ledger changed the base branch from develop to release June 21, 2024 09:22
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@ledgerhq/[email protected] None 0 528 kB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 2.44 MB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 767 kB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 4.97 MB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 1.63 MB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 466 kB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 3.04 MB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 1.4 MB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 514 kB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 259 kB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 164 kB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 464 kB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 23.3 kB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 142 kB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 2.02 MB aboissiere, gbrahm-ledger, ldg-github-ci, ...4 more
npm/@ledgerhq/[email protected] None 0 59.5 kB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 105 kB ldg-github-ci
npm/@ledgerhq/[email protected] Transitive: eval +7 32.3 MB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 142 kB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 822 kB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 132 kB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 131 kB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 317 kB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 3.48 MB ldg-github-ci
npm/@ledgerhq/[email protected] None 0 0 B
npm/@ledgerhq/[email protected] None 0 364 kB ldg-github-ci

🚮 Removed packages: npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected]

View full report↗︎

@live-github-bot
Copy link
Contributor

live-github-bot bot commented Jun 21, 2024

Mobile Bundle Checks

Comparing 38a18fd against 02f6ec0.

⚠️ main.ios.jsbundle bundle size significantly increased: 59.6mb -> 59.9mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 59.6mb -> 60mb. Please check if this is expected.

Desktop Bundle Checks

Comparing 38a18fd against 2426fa5.

@jdabbech-ledger jdabbech-ledger merged commit 612fd82 into release Jun 21, 2024
52 of 58 checks passed
@jdabbech-ledger jdabbech-ledger deleted the bugfix/LIVE-12734-fw-update-language-pack branch June 21, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants