-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [LIVE-12734] [LLD] Device disconnect during restore apps on LNX causing the app restore to fail #7157
Merged
jdabbech-ledger
merged 3 commits into
release
from
bugfix/LIVE-12734-fw-update-language-pack
Jun 21, 2024
Merged
🐛 [LIVE-12734] [LLD] Device disconnect during restore apps on LNX causing the app restore to fail #7157
jdabbech-ledger
merged 3 commits into
release
from
bugfix/LIVE-12734-fw-update-language-pack
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Ignored Deployments
|
jdabbech-ledger
force-pushed
the
bugfix/LIVE-12734-fw-update-language-pack
branch
from
June 21, 2024 09:21
d92bdc9
to
38a18fd
Compare
live-github-bot
bot
added
mobile
Has changes in LLM
common
Has changes in live-common
ui
Has changes in the design system library
ledgerjs
Has changes in the ledgerjs open source libs
cli
labels
Jun 21, 2024
Wiz Scan Summary
|
Mobile Bundle Checks
Desktop Bundle Checks |
aussedatlo
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changeset
was attached.📝 Description
Investigations for this bug:
e0500000
, which is bad formatted, was sent to the device (https://ledgerhq.atlassian.net/browse/LIVE-5273), we chose to delete it as it has no impact to get device/set device on LLM or LLDe053000000
APDUAfter several tests that leaded to random behaviors, a trivial solution was to reset the dashboard with the app restauration list after disconnection.
❓ Context
🧐 Checklist for the PR Reviewers
live-12734.mp4