Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(trustchain): getMembers should be Unauthorized if no longer member #7236

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

gre
Copy link
Contributor

@gre gre commented Jul 1, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • test

πŸ“ Description

  • scenario: rename removedMemberEjected to removedMemberEjectedOnRestore
  • add a few scenario tests related to permissions: to confirm that trying to list members when no longer in the list will not be authorized

❓ Context

  • JIRA or GitHub link: live-13201

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Jul 1, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jul 11, 2024 6:32am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jul 11, 2024 6:32am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jul 11, 2024 6:32am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jul 11, 2024 6:32am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jul 11, 2024 6:32am

@live-github-bot
Copy link
Contributor

live-github-bot bot commented Jul 1, 2024

Desktop Bundle Checks

Comparing 0aebc49 against c0f4803.

βœ… Previous issues have all been fixed.

Mobile Bundle Checks

Comparing 0aebc49 against c0f4803.

βœ… Previous issues have all been fixed.

Comment on lines +8 to +16
// first member initializes itself
const name1 = "Member 1";
const sdk1 = getSdk(!!getEnv("MOCK"), { applicationId, name: name1 });
const member1creds = await sdk1.initMemberCredentials();
// second member initializes itself
const name2 = "Member 2";
const sdk2 = getSdk(!!getEnv("MOCK"), { applicationId, name: name2 });
const member2creds = await sdk2.initMemberCredentials();
const member2 = { name: name2, id: member2creds.pubkey, permissions: 0xffffffff };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we use this on every test, we could make an helper to create that no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes probably.
like #7262 has done it for the sdkForName one πŸ‘

@gre gre merged commit bcfe297 into develop Jul 11, 2024
52 of 59 checks passed
@gre gre deleted the live-13201 branch July 11, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants