Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: LIVE-13226 polkadot send for runtime upgrade #7245

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

hzheng-ledger
Copy link
Contributor

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • **Impact of the changes: no impact
    • ...

πŸ“ Description

In react-native, the "app.signWithMetadata" method returns a polkadot signature. It is not a Buffer type variable, we need to cast it to Buffer explicitly. It is only related to Ledger Live mobile app.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@hzheng-ledger hzheng-ledger requested a review from a team as a code owner July 2, 2024 12:41
Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jul 2, 2024 0:46am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Jul 2, 2024 0:46am
ledger-live-github-bot ⬜️ Ignored (Inspect) Jul 2, 2024 0:46am
native-ui-storybook ⬜️ Ignored (Inspect) Jul 2, 2024 0:46am
react-ui-storybook ⬜️ Ignored (Inspect) Jul 2, 2024 0:46am

@live-github-bot live-github-bot bot added common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Jul 2, 2024
@valpinkman valpinkman merged commit fe1cdec into hotfix Jul 2, 2024
36 of 49 checks passed
@valpinkman valpinkman deleted the bugfix/LIVE-13226-DOT-SEND-LLM-hotfix branch July 2, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants