Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ’„ [LLD/LLM]: Europa assets #7291

Merged
merged 17 commits into from
Jul 22, 2024
Merged

Conversation

jdabbech-ledger
Copy link
Contributor

@jdabbech-ledger jdabbech-ledger commented Jul 9, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • replace assets for europa at build time

πŸ“ Description

This PR aims to replace europa assets at build time:

  • lottie animations for LLM/LLD
  • LLD/LLM onboarding device selection
  • LLD/LLM pnboarding success animation
  • LLD manager device
  • LLM device icons
  • LLM/LLD custom lock screen assets
    The assets are hosted in https://github.com/LedgerHQ/ledger-live-internal-assets and two steps more are running in build/release desktop and mobile worflows.

To replace assets locally:

  • git clone https://github.com/LedgerHQ/ledger-live-internal-assets in ledger-live root folder
  • pnpm desktop assets:replace (LLD)
  • pnpm mobile assets:replace (LLM)

❓ Context

  • JIRA or GitHub link: [DSDK-13125]

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@jdabbech-ledger jdabbech-ledger requested review from a team as code owners July 9, 2024 07:24
Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 2:03pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 2:03pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 2:03pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 2:03pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 2:03pm

@jdabbech-ledger jdabbech-ledger marked this pull request as draft July 9, 2024 07:24
@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM automation CI/CD stuff labels Jul 9, 2024
@live-github-bot live-github-bot bot added the tools Has changes in tools label Jul 9, 2024
@jdabbech-ledger jdabbech-ledger force-pushed the feat/dsdk-13125-live-assets branch 5 times, most recently from a6e9088 to b3654ae Compare July 9, 2024 13:04
@live-github-bot live-github-bot bot removed the tools Has changes in tools label Jul 9, 2024
@jdabbech-ledger jdabbech-ledger force-pushed the feat/dsdk-13125-live-assets branch 8 times, most recently from 751fc40 to e74eb5f Compare July 10, 2024 08:22
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Jul 10, 2024

Mobile Bundle Checks

Comparing d05bf1a against 64d3dc0.

⚠️ main.ios.jsbundle bundle size significantly increased: 59.8mb -> 61.5mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 59.8mb -> 61.5mb. Please check if this is expected.

Desktop Bundle Checks

Comparing d05bf1a against 64d3dc0.

βœ… Previous issues have all been fixed.

@jdabbech-ledger jdabbech-ledger force-pushed the feat/dsdk-13125-live-assets branch 5 times, most recently from fb5b426 to fa5194c Compare July 11, 2024 14:40
@jdabbech-ledger jdabbech-ledger changed the base branch from develop to hotfix July 22, 2024 13:59
@jdabbech-ledger jdabbech-ledger requested review from a team as code owners July 22, 2024 13:59
@jdabbech-ledger jdabbech-ledger merged commit 3abc6d7 into hotfix Jul 22, 2024
54 of 73 checks passed
@jdabbech-ledger jdabbech-ledger deleted the feat/dsdk-13125-live-assets branch July 22, 2024 15:04
jdabbech-ledger added a commit that referenced this pull request Jul 23, 2024
jdabbech-ledger added a commit that referenced this pull request Jul 23, 2024
jdabbech-ledger added a commit that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD stuff desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM screenshots Screenshots have been updated ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants