-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π [LLD/LLM]: Europa assets #7291
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git βοΈ 5 Skipped Deployments
|
live-github-bot
bot
added
desktop
Has changes in LLD
mobile
Has changes in LLM
automation
CI/CD stuff
labels
Jul 9, 2024
jdabbech-ledger
force-pushed
the
feat/dsdk-13125-live-assets
branch
from
July 9, 2024 07:54
b3b1b21
to
7086838
Compare
jdabbech-ledger
force-pushed
the
feat/dsdk-13125-live-assets
branch
5 times, most recently
from
July 9, 2024 13:04
a6e9088
to
b3654ae
Compare
jdabbech-ledger
force-pushed
the
feat/dsdk-13125-live-assets
branch
8 times, most recently
from
July 10, 2024 08:22
751fc40
to
e74eb5f
Compare
Mobile Bundle Checks
Desktop Bundle Checksβ Previous issues have all been fixed. |
jdabbech-ledger
force-pushed
the
feat/dsdk-13125-live-assets
branch
5 times, most recently
from
July 11, 2024 14:40
fb5b426
to
fa5194c
Compare
ypolishchuk-ledger
approved these changes
Jul 22, 2024
jdabbech-ledger
force-pushed
the
feat/dsdk-13125-live-assets
branch
from
July 22, 2024 14:00
fbbee33
to
990ec6d
Compare
jdabbech-ledger
force-pushed
the
feat/dsdk-13125-live-assets
branch
from
July 22, 2024 14:02
990ec6d
to
d05bf1a
Compare
Justkant
approved these changes
Jul 22, 2024
jdabbech-ledger
added a commit
that referenced
this pull request
Jul 23, 2024
π [LLD/LLM]: Europa assets
jdabbech-ledger
added a commit
that referenced
this pull request
Jul 23, 2024
π [LLD/LLM]: Europa assets
jdabbech-ledger
added a commit
that referenced
this pull request
Jul 23, 2024
π [LLD/LLM]: Europa assets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automation
CI/CD stuff
desktop
Has changes in LLD
ledgerjs
Has changes in the ledgerjs open source libs
mobile
Has changes in LLM
screenshots
Screenshots have been updated
ui
Has changes in the design system library
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
β Checklist
npx changeset
was attached.π Description
This PR aims to replace europa assets at build time:
The assets are hosted in https://github.com/LedgerHQ/ledger-live-internal-assets and two steps more are running in build/release desktop and mobile worflows.
To replace assets locally:
git clone https://github.com/LedgerHQ/ledger-live-internal-assets
in ledger-live root folderpnpm desktop assets:replace
(LLD)pnpm mobile assets:replace
(LLM)β Context
π§ Checklist for the PR Reviewers