LLD integration of Wallet Sync #7300

gre · 2024-07-09T16:00:12Z

✅ Checklist

npx changeset was attached.
Covered by automatic tests.
Impact of the changes:
- LLD when trustchain is active

📝 Description

This integrates Wallet Sync feature on LLD.

walletSyncWatchLoop is integrated in LLD.
error automatic handling (removing someone in the members, it will detects that it needs to restoreTrustchain, if member is yourself it will also automatically ejects)
UI: error and pending state are displayed on the global ✅ Synchronized top activity banner.

❓ Context

JIRA or GitHub link: live-12636

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

vercel · 2024-07-09T16:00:15Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
web-tools	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 18, 2024 3:11pm

4 Skipped Deployments

Name	Status	Preview	Updated (UTC)
ledger-live-docs	⬜️ Ignored (Inspect)	Visit Preview	Jul 18, 2024 3:11pm
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview	Jul 18, 2024 3:11pm
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Jul 18, 2024 3:11pm
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Jul 18, 2024 3:11pm

apps/ledger-live-desktop/src/newArch/WalletSync/hooks/useWatchWalletSync.ts

.changeset/nasty-windows-suffer.md

apps/ledger-live-desktop/src/newArch/WalletSync/hooks/useWatchWalletSync.ts

apps/ledger-live-desktop/src/newArch/WalletSync/hooks/useTrustchainSdk.ts

apps/ledger-live-desktop/src/renderer/init.tsx

chore: kickoff LLD integration of wallet sync

github-actions bot assigned gre Jul 9, 2024

live-github-bot bot added the desktop Has changes in LLD label Jul 9, 2024

vercel bot deployed to Preview – web-tools July 9, 2024 16:03 View deployment

gre assigned mcayuelas-ledger Jul 9, 2024

gre force-pushed the live-12636 branch from a00f558 to d45e231 Compare July 11, 2024 16:52

vercel bot had a problem deploying to Preview – web-tools July 11, 2024 16:54 Failure

gre force-pushed the live-12636 branch from d45e231 to b9208c1 Compare July 11, 2024 17:01

vercel bot had a problem deploying to Preview – web-tools July 11, 2024 17:03 Failure

gre force-pushed the live-12636 branch from b9208c1 to 4b95926 Compare July 11, 2024 17:35

vercel bot deployed to Preview – web-tools July 11, 2024 17:39 View deployment

gre force-pushed the live-12636 branch from 4b95926 to f76df12 Compare July 11, 2024 18:27

vercel bot deployed to Preview – web-tools July 11, 2024 18:28 View deployment

vercel bot deployed to Preview – web-tools July 15, 2024 08:32 View deployment

gre force-pushed the live-12636 branch 2 times, most recently from 6addd89 to 750bee1 Compare July 15, 2024 09:06

vercel bot deployed to Preview – web-tools July 15, 2024 09:11 View deployment

gre force-pushed the live-12636 branch 2 times, most recently from 28dbb71 to 8159e9e Compare July 15, 2024 11:59

vercel bot deployed to Preview – web-tools July 15, 2024 12:05 View deployment

gre force-pushed the live-12636 branch from 8159e9e to 6ff56c6 Compare July 15, 2024 12:15

vercel bot deployed to Preview – web-tools July 15, 2024 12:17 View deployment

gre force-pushed the live-12636 branch from 6ff56c6 to 8a82f8a Compare July 15, 2024 13:08

vercel bot deployed to Preview – web-tools July 15, 2024 13:12 View deployment

gre force-pushed the live-12636 branch from 8a82f8a to 568fd91 Compare July 15, 2024 13:16

gre unassigned mcayuelas-ledger Jul 15, 2024

vercel bot deployed to Preview – web-tools July 15, 2024 13:18 View deployment

gre marked this pull request as ready for review July 15, 2024 13:32

gre requested review from a team as code owners July 15, 2024 13:32

mcayuelas-ledger reviewed Jul 15, 2024

View reviewed changes

apps/ledger-live-desktop/src/newArch/WalletSync/hooks/useWatchWalletSync.ts Outdated Show resolved Hide resolved

.changeset/nasty-windows-suffer.md Outdated Show resolved Hide resolved

vercel bot deployed to Preview – web-tools July 15, 2024 13:34 View deployment

mcayuelas-ledger reviewed Jul 15, 2024

View reviewed changes

apps/ledger-live-desktop/src/newArch/WalletSync/hooks/useWatchWalletSync.ts Outdated Show resolved Hide resolved

gre mentioned this pull request Jul 15, 2024

chore(wallet): fixes cloudsync api parser on out-of-sync info nullable #7336

Merged

3 tasks

gre force-pushed the live-12636 branch from 89e3500 to 8b52186 Compare July 15, 2024 15:05

vercel bot deployed to Preview – web-tools July 15, 2024 15:11 View deployment

gre mentioned this pull request Jul 15, 2024

chore(walletsync): improve walletsync lib #7337

Merged

3 tasks

gre force-pushed the live-12636 branch from 8b52186 to ceefbda Compare July 15, 2024 15:29

vercel bot had a problem deploying to Preview – web-tools July 15, 2024 15:31 Failure

gre marked this pull request as draft July 15, 2024 15:34

gre force-pushed the live-12636 branch 2 times, most recently from da584fa to 1f22f3d Compare July 16, 2024 07:24

vercel bot deployed to Preview – web-tools July 16, 2024 07:27 View deployment

gre force-pushed the live-12636 branch from 1f22f3d to 2325950 Compare July 16, 2024 07:57

vercel bot had a problem deploying to Preview – web-tools July 16, 2024 07:59 Failure

gre force-pushed the live-12636 branch from 2325950 to d431534 Compare July 16, 2024 08:16

gre marked this pull request as ready for review July 16, 2024 15:54

gre removed the request for review from a team July 16, 2024 15:54

gre force-pushed the live-12636 branch from f123228 to d431534 Compare July 18, 2024 08:04

gre mentioned this pull request Jul 18, 2024

[FEAT] : Activation Flow with Trustchain #7352

Merged

3 tasks

cgrellard-ledger reviewed Jul 18, 2024

View reviewed changes

chore: kickoff LLD integration of wallet sync

d2e521f

gre force-pushed the live-12636 branch from d431534 to d2e521f Compare July 18, 2024 15:07

vercel bot deployed to Preview – web-tools July 18, 2024 15:11 View deployment

cgrellard-ledger approved these changes Jul 18, 2024

View reviewed changes

mcayuelas-ledger approved these changes Jul 18, 2024

View reviewed changes

gre merged commit d026c19 into develop Jul 18, 2024
49 of 53 checks passed

gre deleted the live-12636 branch July 18, 2024 15:48

KVNLS pushed a commit that referenced this pull request Jul 19, 2024

LLD integration of Wallet Sync (#7300)

f7ef69c

chore: kickoff LLD integration of wallet sync

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LLD integration of Wallet Sync #7300

LLD integration of Wallet Sync #7300

gre commented Jul 9, 2024 •

edited

Loading

vercel bot commented Jul 9, 2024 •

edited

Loading

LLD integration of Wallet Sync #7300

LLD integration of Wallet Sync #7300

Conversation

gre commented Jul 9, 2024 • edited Loading

✅ Checklist

📝 Description

❓ Context

🧐 Checklist for the PR Reviewers

vercel bot commented Jul 9, 2024 • edited Loading

gre commented Jul 9, 2024 •

edited

Loading

vercel bot commented Jul 9, 2024 •

edited

Loading