Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(LLD): AccountList not showing the correct name and balance for tokens [CN-142] #7321

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

Justkant
Copy link
Contributor

@Justkant Justkant commented Jul 11, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • All live-apps that use the account selection with tokens
    • buy/sell
    • earn

📝 Description

AccountList not showing the correct name and balance for tokens
Introduced in this big PR: #6796
It's hard to catch this kind of bug, so it should be covered now with the test

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@Justkant Justkant requested a review from a team July 11, 2024 16:09
@Justkant Justkant self-assigned this Jul 11, 2024
@Justkant Justkant requested review from a team as code owners July 11, 2024 16:09
Copy link

vercel bot commented Jul 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Jul 11, 2024 4:09pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Jul 11, 2024 4:09pm
native-ui-storybook ⬜️ Ignored (Inspect) Jul 11, 2024 4:09pm
react-ui-storybook ⬜️ Ignored (Inspect) Jul 11, 2024 4:09pm
web-tools ⬜️ Ignored (Inspect) Jul 11, 2024 4:09pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jul 11, 2024
@Justkant Justkant merged commit 471ce30 into develop Jul 12, 2024
34 of 37 checks passed
@Justkant Justkant deleted the bugfix/CN-142 branch July 12, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants