Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💄 [FEAT] : WalletSyncActivated Landing page #7381

Merged
merged 19 commits into from
Jul 24, 2024
Merged

💄 [FEAT] : WalletSyncActivated Landing page #7381

merged 19 commits into from
Jul 24, 2024

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Jul 19, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

WalletSyncActivated Landing Page

DEMO

Screenshot_20240719_163410_LL DEV

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Jul 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 2:51pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 2:51pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 2:51pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 2:51pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jul 22, 2024 2:51pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Jul 19, 2024
@mcayuelas-ledger mcayuelas-ledger marked this pull request as ready for review July 19, 2024 14:55
@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner July 19, 2024 14:55
@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner July 19, 2024 14:56
LucasWerey
LucasWerey reviewed Jul 22, 2024
View reviewed changes
apps/ledger-live-mobile/src/newArch/features/WalletSync/WalletSyncNavigator.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier issues here

Base automatically changed from feat/intregate-trustchain-llm to develop July 22, 2024 14:40
@mcayuelas-ledger mcayuelas-ledger merged commit 29d2d37 into develop Jul 24, 2024
35 of 37 checks passed
@mcayuelas-ledger mcayuelas-ledger deleted the feat/wallet-sync-activated branch July 24, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KVNLS KVNLS KVNLS approved these changes

@LucasWerey LucasWerey Awaiting requested review from LucasWerey

Assignees

@mcayuelas-ledger mcayuelas-ledger

Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mcayuelas-ledger @KVNLS @LucasWerey @gre