Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(trustchain): fix recordTrustchainSdkTests to await button actions #7396

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

gre
Copy link
Contributor

@gre gre commented Jul 22, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • trustchain tests

πŸ“ Description

fix race conditions that can make pnpm trustchain e2e fails with socket hangs up error in speculos due to not waiting the termination of all button actions that was performed.

❓ Context

  • JIRA or GitHub link: na

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@gre gre requested a review from a team as a code owner July 22, 2024 17:12
Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jul 22, 2024 5:14pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Jul 22, 2024 5:14pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Jul 22, 2024 5:14pm
native-ui-storybook ⬜️ Ignored (Inspect) Jul 22, 2024 5:14pm
react-ui-storybook ⬜️ Ignored (Inspect) Jul 22, 2024 5:14pm

Copy link
Contributor

@thesan thesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@gre gre merged commit b8aa007 into develop Jul 23, 2024
57 checks passed
@gre gre deleted the bugfix-recordTrustchainSdkTests branch July 23, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants