-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LIVE-3254 - LLM - Wallet connect as live app feature flag #899
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
π¦ Changeset detectedLatest commit: 6d48688 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0f06462
to
cc7fb19
Compare
Codecov Report
@@ Coverage Diff @@
## develop #899 +/- ##
============================================
- Coverage 71.71% 43.91% -27.81%
============================================
Files 44 609 +565
Lines 2850 25584 +22734
Branches 555 6963 +6408
============================================
+ Hits 2044 11234 +9190
- Misses 801 14301 +13500
- Partials 5 49 +44
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Screenshots: β
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
324af39
to
b3b30ef
Compare
b3b30ef
to
b0f5936
Compare
There as been no activity on this PR for the last 14 days. Please consider closing this PR. |
fe23dd0
to
b2b4c49
Compare
078ed93
to
26dd67b
Compare
26dd67b
to
b4bf220
Compare
b4bf220
to
efc36d7
Compare
efc36d7
to
bf86838
Compare
bf86838
to
32d9916
Compare
replaced scan: true by mode: "scan" tweaked react-native webview prevent undefined params to be passed to the live app (dangerous) fix: wallet connect deeplink update uri instead of pushing a new screen fix: handle wallet connect invalid links
32d9916
to
6d48688
Compare
π Description
Implement routing logic to either use the native of live app implementation of wallet connect in the live using a feature flag.
β Context
ledger-live-mobile
β Checklist
πΈ Demo
π Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.