Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIVE-3254 - LLM - Wallet connect as live app feature flag #899

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

LFBarreto
Copy link
Contributor

@LFBarreto LFBarreto commented Aug 10, 2022

πŸ“ Description

Implement routing logic to either use the native of live app implementation of wallet connect in the live using a feature flag.

❓ Context

  • Impacted projects: ledger-live-mobile
  • Linked resource(s): LIVE-3254

βœ… Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

πŸ“Έ Demo

πŸš€ Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vercel
Copy link

vercel bot commented Aug 10, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
live-common-tools βœ… Ready (Inspect) Visit Preview Sep 7, 2022 at 0:04AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 7, 2022 at 0:04AM (UTC)
native-ui-storybook ⬜️ Ignored (Inspect) Sep 7, 2022 at 0:04AM (UTC)
react-ui-storybook ⬜️ Ignored (Inspect) Sep 7, 2022 at 0:04AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2022

πŸ¦‹ Changeset detected

Latest commit: 6d48688

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
live-mobile Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM labels Aug 10, 2022
@LFBarreto LFBarreto force-pushed the feat/LIVE-3254-wallet-connect-live-app branch from 0f06462 to cc7fb19 Compare August 10, 2022 14:41
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #899 (b6fad5e) into develop (0f4a12a) will decrease coverage by 27.80%.
The diff coverage is n/a.

❗ Current head b6fad5e differs from pull request most recent head 6d48688. Consider uploading reports for the commit 6d48688 to get more accurate results

@@             Coverage Diff              @@
##           develop     #899       +/-   ##
============================================
- Coverage    71.71%   43.91%   -27.81%     
============================================
  Files           44      609      +565     
  Lines         2850    25584    +22734     
  Branches       555     6963     +6408     
============================================
+ Hits          2044    11234     +9190     
- Misses         801    14301    +13500     
- Partials         5       49       +44     
Flag Coverage Ξ”
test 43.91% <ΓΈ> (-27.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
...dgerjs/packages/hw-app-btc/src/getAppAndVersion.ts
...rjs/packages/hw-app-btc/src/signP2SHTransaction.ts
...erjs/packages/hw-app-btc/src/getWalletPublicKey.ts
libs/ledgerjs/packages/hw-app-trx/src/Trx.ts
...js/packages/hw-app-btc/src/serializeTransaction.ts
...s/hw-app-btc/src/shouldUseTrustedInputForSegwit.ts
libs/ledgerjs/packages/hw-app-str/src/Str.ts
libs/ledgerjs/packages/hw-app-str/src/utils.ts
.../ledgerjs/packages/hw-app-btc/src/newops/merkle.ts
...gerjs/packages/hw-app-btc/src/compressPublicKey.ts
... and 643 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Aug 10, 2022

@Justkant

Screenshots: βœ…

There are no changes in the screenshots for this PR. If this is expected, you are good to go.

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

replaced scan: true by mode: "scan"

tweaked react-native webview

prevent undefined params to be passed to the live app (dangerous)

fix: wallet connect deeplink update uri instead of pushing a new screen

fix: handle wallet connect invalid links
@Justkant Justkant force-pushed the feat/LIVE-3254-wallet-connect-live-app branch from 32d9916 to 6d48688 Compare September 7, 2022 12:01
@Justkant Justkant merged commit 68c2c0c into develop Sep 7, 2022
@Justkant Justkant deleted the feat/LIVE-3254-wallet-connect-live-app branch September 7, 2022 13:03
@desirendr desirendr added this to the Ledger Live Mobile 3.8.x milestone Sep 8, 2022
@desirendr desirendr added translations Translation files have been touched and removed translations Translation files have been touched labels Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants