-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/FAT 156 - LLM Post onboarding #943
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: ee7bbe3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
69f8c0f
to
2ffe450
Compare
Codecov Report
@@ Coverage Diff @@
## develop #943 +/- ##
===========================================
+ Coverage 48.09% 48.22% +0.13%
===========================================
Files 674 687 +13
Lines 30085 30219 +134
Branches 7840 7857 +17
===========================================
+ Hits 14468 14573 +105
- Misses 15557 15586 +29
Partials 60 60
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
5eff059
to
bd4b476
Compare
e87f8c0
to
c3f2bb4
Compare
c3f2bb4
to
c71f294
Compare
apps/ledger-live-mobile/src/components/PostOnboarding/PostOnboardingActionRow.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-mobile/src/components/PostOnboarding/PostOnboardingActionRow.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-mobile/src/components/PostOnboarding/PostOnboardingActionRow.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-mobile/src/components/PostOnboarding/PostOnboardingEntryPointCard.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-mobile/src/components/PostOnboarding/PostOnboardingEntryPointCard.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-mobile/src/screens/PostOnboarding/PostOnboardingHub.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-mobile/src/screens/PostOnboarding/PostOnboardingHub.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-mobile/src/screens/PostOnboarding/PostOnboardingHub.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-mobile/src/screens/PostOnboarding/PostOnboardingHub.tsx
Outdated
Show resolved
Hide resolved
f7fc194
to
ec3c8cd
Compare
b978e14
to
245a435
Compare
245a435
to
6304fce
Compare
60c784f
to
e2b691b
Compare
author Olivier Freyssinet <[email protected]> 1660815558 +0200 committer Olivier F <[email protected]> 1661187186 +0200 feat: post onboarding PostOnboardingHub screen ground work + debug settings + screen for mocking features with "done" button Use correct typo for title & subtitle of hub screen Add largeLineHeight variant to native-ui text Use correct typographic styles & colors in post onboarding hub Move post onboarding types to LLC Add POST_ONBOARDING_CLEAR_LAST_ACTION_COMPLETED action fix bracketSizes type Rename & document hooks Fix PostOnboardingMockActionScreen Move post onboarding to own navigator Clear last action completed when leaving closing hub screen feat(native-ui): new variant "plain" for Notification component Implement logic for closing popup in PostOnboardingHub Fix bad style in native-ui getTextStyle (missing unit in styled component) Remove "all done" state confettis in hub Reword "setActionDone" to "setActionCompleted" Fix import of postOnboardingState (don't add to store if value is falsy) Add post onboarding entry point on portfolio/wallet screen Implement new tag variants from figma Change icons & shorten text of mock post onboarding actions Use new tag styling Set logic for mocking post onboarding actions Add animated success screen Improve placeholder text Cleanup (rename mock actions as such, cleanup documentation, remove useless hook) Improve wording of debug settings Fix warning in PostOnboardingHub Fix post rebase Fix color of placeholder img in entry point card Fix feature flagging of post onboarding actions lint Tag component changesets Add guides for implementation of post onboarding action for each device model Add startPostOnboarding at the end of existing onboarding Fix useStartPostOnboardingCallback not always overriding state Improve navigation to main screen lint changeset Migrate postOnboarding types to types-live Add tracking of post onboarding action start docs & rename ActionState type Remove placeholder type Better use of design system spacing & radii scales Rename `icon` > `Icon` to follow component naming convention Use deep comparison of post onboarding state before saving it in db Cleanup some types & comments Fix potential crash on falsy value lint Use Divider from design system Add todos Try moving state logic to LLC (not working for now bc of react-redux) pnpm i remove /lib/postOnboarding imports remove /lib imports in postOnboarding/hooks Revert change on portfolio index Force react-redux dep in LLM metro config (thank you Julien you saved the day 🙏) chore: remove react-native from react-redux peer deps Slightly more elegant way of fixing LLM/LLC react-redux duplicate package issues live-common changesets Fix bad use of importPostOnboardingState action creator lint install deps post rebase fix bad merge fix reducer missing post rebase Fix ts (post rebase) Force react-redux dep in LLM metro config chore: remove react-dom from react-redux peer deps Fix typing of PostOnboardingProvider props Move hooks to their own file rename hooks.tsx to useNavigateToPostOnboardingHubCallback.ts no import from "." Remove log some unit tests, more coming tomorrow this is boring to death Add tests for usePostOnboardingHubState Unit test postOnboarding reducer & actions creators give this code some room to breathe fix PostOnboarding routes typing improve test clarity fix post rebase fix doc remove @ts-expect-error lint lint again lint Fix post rebase Fix post rebase Fix remove bad comment on portfolio Remove useless hooks Rename onStartEvent->startEvent, onStartEventProperties->startEventProperties File apps/ledger-live-mobile/src/locales/en/common.json was updated on ru-RU locale File apps/ledger-live-mobile/src/locales/en/common.json was updated on de-DE locale File apps/ledger-live-mobile/src/locales/en/common.json was updated on ko-KR locale File apps/ledger-live-mobile/src/locales/en/common.json was updated on pt-BR locale File apps/ledger-live-mobile/src/locales/en/common.json was updated on es-ES locale File apps/ledger-live-mobile/src/locales/en/common.json was updated on tr-TR locale File apps/ledger-live-mobile/src/locales/en/common.json was updated on ar-AE locale File apps/ledger-live-mobile/src/locales/en/common.json was updated on fr-FR locale File apps/ledger-live-mobile/src/locales/en/common.json was updated on zh-CN locale File apps/ledger-live-mobile/src/locales/en/common.json was updated on ja-JP locale Prevent closing the onboarding hub during the end animation Add delay prop to Transitions.Fade Fade out the notification at the bottom doc:ljs Remove usePostOnboardingDeviceModelId, useSetActionCompletedCallback lint fix post rebase
677ff3b
to
fefe72c
Compare
apps/ledger-live-mobile/src/screens/PostOnboarding/PostOnboardingHub.tsx
Show resolved
Hide resolved
apps/ledger-live-mobile/src/screens/PostOnboarding/PostOnboardingHub.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-mobile/src/screens/PostOnboarding/PostOnboardingHub.tsx
Outdated
Show resolved
Hide resolved
libs/ledger-live-common/src/postOnboarding/hooks/usePostOnboardingContext.ts
Show resolved
Hide resolved
…onboarding (#1251) * File apps/ledger-live-mobile/src/locales/en/common.json was updated on ru-RU locale * File apps/ledger-live-mobile/src/locales/en/common.json was updated on de-DE locale * File apps/ledger-live-mobile/src/locales/en/common.json was updated on ko-KR locale * File apps/ledger-live-mobile/src/locales/en/common.json was updated on pt-BR locale * File apps/ledger-live-mobile/src/locales/en/common.json was updated on es-ES locale * File apps/ledger-live-mobile/src/locales/en/common.json was updated on tr-TR locale * File apps/ledger-live-mobile/src/locales/en/common.json was updated on ar-AE locale * File apps/ledger-live-mobile/src/locales/en/common.json was updated on fr-FR locale * File apps/ledger-live-mobile/src/locales/en/common.json was updated on zh-CN locale * File apps/ledger-live-mobile/src/locales/en/common.json was updated on ja-JP locale
apps/ledger-live-mobile/src/screens/PostOnboarding/PostOnboardingHub.tsx
Show resolved
Hide resolved
the requested changes (including tests of hooks) have been implemented
📝 Description
Implementation of the post onboarding logic & UI.
After a user is done with setting up a device (onboarding flow), we want to guide this user to some features so that they can get the best out of they device. For that, we are adding a new "post onboarding" flow that will be triggered at the end of the onboarding and that will have 1 (dismissable) entry point on the wallet screen.
For now none of the features that we want to add in the post onboarding hub are developed so this PR just covers the implementation of the logic & of the UI of the post onboarding. The post onboarding is triggered automatically at the end of the onboarding, but as there are no implemented post onboarding actions yet, it will not change anything from a user perspective.
It adds:
ledgerjs
ledger-live-common
ledger-live-mobile
native-ui
Alert
component.Separately (because different repo): I've documented on the wiki how to implement a new post onboarding action
How to test (for QA) ?
❓ Context
ledger-live-mobile
native-ui
✅ Checklist
📸 Demo
Simulator.Screen.Recording.-.iPhone.13.-.2022-08-18.at.13.03.59.mp4
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.